Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] Fixes description of Import rules modal #118216

Merged
merged 1 commit into from Nov 11, 2021
Merged

[Security Solution][Detections] Fixes description of Import rules modal #118216

merged 1 commit into from Nov 11, 2021

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Nov 10, 2021 •
edited

Issue #115537

Summary

Changing outdate description on Import rules modal to "Select rules and actions (as exported from the Security > Rules page) to import"

Screenshots

Before

Screenshot 2021-11-10 at 18 50 42

After

Screenshot 2021-11-10 at 18 49 13

Checklist

@vitaliidm vitaliidm added auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team v7.16.0 v7.16.1 v8.0.0 release_note:fix labels Nov 10, 2021
@vitaliidm vitaliidm requested a review from a team November 10, 2021 18:47
@vitaliidm vitaliidm self-assigned this Nov 10, 2021
@vitaliidm vitaliidm changed the title [Security Solution][Detections] Fix description of Import rules modal [Security Solution][Detections] Fixes description of Import rules modal Nov 10, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.5MB 4.5MB +4.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm removed the v7.16.1 label Nov 11, 2021
@banderror banderror marked this pull request as ready for review November 11, 2021 10:07
@banderror banderror requested a review from a team as a code owner November 11, 2021 10:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror
banderror approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vitaliidm 👍

@vitaliidm vitaliidm merged commit c0cb59b into elastic:main Nov 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2021
@vitaliidm @kibanamachine
Change Import Rules Modal Description (elastic#118216)
738b3d0
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 11, 2021
@vitaliidm @kibanamachine
Change Import Rules Modal Description (elastic#118216)
b8ff476
@kibanamachine kibanamachine mentioned this pull request Nov 11, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Nov 11, 2021
@kibanamachine @vitaliidm
Change Import Rules Modal Description (#118216) (#118316)
e671b45 
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Nov 11, 2021
@kibanamachine @vitaliidm
Change Import Rules Modal Description (#118216) (#118317)
7ff181a 
Co-authored-by: Vitalii Dmyterko <92328789+vitaliidm@users.noreply.github.com>
@vitaliidm vitaliidm deleted the change-import-rule-modal-description branch November 11, 2021 13:36
claudiopro pushed a commit to claudiopro/kibana that referenced this pull request Nov 11, 2021
@vitaliidm @claudiopro
Change Import Rules Modal Description (elastic#118216)
de07721
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 17, 2021
@vitaliidm @fkanout
Change Import Rules Modal Description (elastic#118216)
5aa87fe
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
@vitaliidm @dmlemeshko
Change Import Rules Modal Description (#118216)
5ed77c9
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
@vitaliidm
Change Import Rules Modal Description (elastic#118216)
4bef4ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

Assignees

@vitaliidm vitaliidm

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged bug Fixes for quality problems that affect the customer experience Feature:Rule Management Security Solution Detection Rule Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.16.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vitaliidm @kibanamachine @elasticmachine @banderror