-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preemptive link fix for stack upgrade page #118832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-docs (Team:Docs) |
💚 Build Succeeded
History
To update your PR or re-run it, just comment with: |
KOTungseth
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kilfoyle
added a commit
to kilfoyle/kibana
that referenced
this pull request
Nov 17, 2021
* Preemptive link fix for stack upgrade page * fix * add html extension
KOTungseth
pushed a commit
that referenced
this pull request
Nov 17, 2021
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Nov 19, 2021
* Preemptive link fix for stack upgrade page * fix * add html extension
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Nov 20, 2021
* Preemptive link fix for stack upgrade page * fix * add html extension
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Preemptive link fix for stack upgrade page * fix * add html extension
roeehub
pushed a commit
to build-security/kibana
that referenced
this pull request
Dec 16, 2021
* Preemptive link fix for stack upgrade page * fix * add html extension
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* Preemptive link fix for stack upgrade page * fix * add html extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm planning changes to the stack upgrade documentation via elastic/stack-docs#1876, which will create a broken link from this Kibana Upgrade from 5.x or earlier section to a page that I am moving.
This fix isn't ideal since I'm redirecting the original link to a parent topic, but:
i) I need to avoid the chicken and egg problem that if I try to point to the exact new location, neither PR can pass CI checks.
ii) 5.x is no longer supported anyway
@KOTungseth or Kibana writers, can you help me with this please? I would like to backport to 8.0 but I'm not sure about the labels/process for that.