Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preemptive link fix for stack upgrade page #118832

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Nov 17, 2021

I'm planning changes to the stack upgrade documentation via elastic/stack-docs#1876, which will create a broken link from this Kibana Upgrade from 5.x or earlier section to a page that I am moving.

This fix isn't ideal since I'm redirecting the original link to a parent topic, but:
i) I need to avoid the chicken and egg problem that if I try to point to the exact new location, neither PR can pass CI checks.
ii) 5.x is no longer supported anyway

@KOTungseth or Kibana writers, can you help me with this please? I would like to backport to 8.0 but I'm not sure about the labels/process for that.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@kilfoyle kilfoyle added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Nov 17, 2021
@kilfoyle kilfoyle requested review from a team and removed request for a team and KOTungseth November 17, 2021 04:53
@kilfoyle kilfoyle marked this pull request as draft November 17, 2021 13:08
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kilfoyle kilfoyle marked this pull request as ready for review November 17, 2021 13:48
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KOTungseth KOTungseth removed the docs label Nov 17, 2021
@kilfoyle kilfoyle merged commit f5935e1 into elastic:main Nov 17, 2021
kilfoyle added a commit to kilfoyle/kibana that referenced this pull request Nov 17, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
KOTungseth pushed a commit that referenced this pull request Nov 17, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
fkanout pushed a commit to fkanout/kibana that referenced this pull request Nov 19, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
TinLe pushed a commit to TinLe/kibana that referenced this pull request Nov 20, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
dmlemeshko pushed a commit that referenced this pull request Nov 29, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
roeehub pushed a commit to build-security/kibana that referenced this pull request Dec 16, 2021
* Preemptive link fix for stack upgrade page

* fix

* add html extension
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
* Preemptive link fix for stack upgrade page

* fix

* add html extension
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants