Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add loader for kibana overview while checking for user data view #118881

Merged
merged 10 commits into from
Nov 19, 2021
Merged

Add loader for kibana overview while checking for user data view #118881

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7ef5289
add loader on overview page
pgayvallet Nov 17, 2021
86ce04c
use KibanaThemeProvider for kibanaOverview
pgayvallet Nov 17, 2021
0d67f5c
change add data label to integrations
pgayvallet Nov 17, 2021
bb0d56a
adapt tests
pgayvallet Nov 17, 2021
dd455bf
update snapshots, remove i18n keys
pgayvallet Nov 18, 2021
56998ed
Merge remote-tracking branch 'upstream/main' into kbn-116411-fix-over…
pgayvallet Nov 19, 2021
5d3abb8
review comments
pgayvallet Nov 19, 2021
7ad6234
Merge branch 'main' into kbn-116411-fix-overview-blink
kibanamachine Nov 19, 2021
13439a0
Merge remote-tracking branch 'upstream/main' into kbn-116411-fix-over…
pgayvallet Nov 19, 2021
efa84a2
Merge remote-tracking branch 'origin/kbn-116411-fix-overview-blink' i…
pgayvallet Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 18 additions & 13 deletions src/plugins/kibana_overview/public/application.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ import React from 'react';
import ReactDOM from 'react-dom';
import { i18n } from '@kbn/i18n';
import { I18nProvider } from '@kbn/i18n/react';
import { KibanaContextProvider } from '../../../../src/plugins/kibana_react/public';
import {
KibanaContextProvider,
KibanaThemeProvider,
} from '../../../../src/plugins/kibana_react/public';
import { NewsfeedApiEndpoint } from '../../../../src/plugins/newsfeed/public';
import { AppMountParameters, CoreStart } from '../../../../src/core/public';
import { AppPluginStartDependencies } from './types';
Expand All @@ -19,7 +22,7 @@ import { KibanaOverviewApp } from './components/app';
export const renderApp = (
core: CoreStart,
deps: AppPluginStartDependencies,
{ appBasePath, element }: AppMountParameters
{ appBasePath, element, theme$ }: AppMountParameters
) => {
const { notifications, http } = core;
const { newsfeed, home, navigation } = deps;
Expand All @@ -37,17 +40,19 @@ export const renderApp = (

ReactDOM.render(
<I18nProvider>
<KibanaContextProvider services={{ ...core, ...deps }}>
<KibanaOverviewApp
basename={appBasePath}
notifications={notifications}
http={http}
navigation={navigation}
newsfeed$={newsfeed$}
solutions={solutions}
features={features}
/>
</KibanaContextProvider>
<KibanaThemeProvider theme$={theme$}>
<KibanaContextProvider services={{ ...core, ...deps }}>
<KibanaOverviewApp
basename={appBasePath}
notifications={notifications}
http={http}
navigation={navigation}
newsfeed$={newsfeed$}
solutions={solutions}
features={features}
/>
</KibanaContextProvider>
</KibanaThemeProvider>
</I18nProvider>,
element
);
Expand Down
Loading