[Console] Fix error markers in editor output

[mibragimov]

Resolve #99083

One way to fix this bug seems to be disabling workers for read-only editor. It get rids of the error markers and does not seem to affect the current behavior of the editor output

[elasticmachine]

Pinging @elastic/kibana-stack-management (Team:Stack Management)

[sabarasaba]

Hey @mibragimov, thanks for having a look at this! From what I could gather disabling the worker will disable the syntax checker from the editor, are we certain this won't change any existing behaviour from the editor? I'm just asking because there's no test coverage for this app and we need to make sure we don't modify any existing functionality. If so, would be nice to add a comment above this line explaining why we're disabling it 🚀

[mibragimov]

Hey @mibragimov, thanks for having a look at this! From what I could gather disabling the worker will disable the syntax checker from the editor, are we certain this won't change any existing behaviour from the editor? I'm just asking because there's no test coverage for this app and we need to make sure we don't modify any existing functionality. If so, would be nice to add a comment above this line explaining why we're disabling it 🚀

Hey @sabarasaba, I did not notice any difference in existing behavior of the editor output, when the worker is disabled. However, I am not certain that this won't affect anything. I think it needs more testing if we go for this solution.

Alternatively, we can hide the element with css. I updated the changes to this. Let me know what you think

[mibragimov]

Hi @sabarasaba, Please, ignore the previous comment. There seems to be a simple way to fix this by replacing json mode with hjson which allows to use comments

[alexwizp]

LGTM! Tested locally. Issue fixed

[sabarasaba]

code LGTM now! thanks @mibragimov!

[mibragimov]

@elasticmachine merge upstream

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: 3e07428
• Storybooks Preview

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
console	157	158	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
console	366.5KB	372.3KB	+5.8KB

History

• 💚 Build #9987 succeeded ad4d379
• 💚 Build #9581 succeeded 5b7e909

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mibragimov