Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Tools Console: Expose the error_trace parameter for completion #120290

Merged
merged 7 commits into from
Dec 13, 2021

Conversation

vladpro25
Copy link
Contributor

@vladpro25 vladpro25 commented Dec 2, 2021

Closes: #98904

Describe the issue:

Similar to the filter_path parameter, there is also a error_trace parameter in order to return full stack trace from Elasticsearch in case an exception is returned.
As this parameter is used a bit on error handling, it is quite tedious to look it up every time, so the user would like it to be available in developer tools requests by default.

Final result

The error_trace parameter was added by default in developer tools requests.

Confirmation

New Project (2)

@vladpro25 vladpro25 added Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0 labels Dec 7, 2021
@vladpro25 vladpro25 self-assigned this Dec 7, 2021
@vladpro25
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexwizp alexwizp added the backport:skip This commit does not require backporting label Dec 8, 2021
@alexwizp alexwizp marked this pull request as ready for review December 8, 2021 15:33
@alexwizp alexwizp requested a review from a team as a code owner December 8, 2021 15:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-management (Team:Stack Management)

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vladpro25, thank you so much for working on this fix!
The file that you are updating is a generated json, that is recreated every time we run a script. So you changes would be lost next time that happens.
Could you please create a file with the same in the overrides folder and add the fix there? The definitions from both folders are then merged together so it's enough to only add the missing parameter.

{
  "search": {
    "url_params": {
      "error_trace": true
    }
  }
}

@vladpro25
Copy link
Contributor Author

@elasticmachine merge upstream

@vladpro25
Copy link
Contributor Author

Hi @vladpro25, thank you so much for working on this fix! The file that you are updating is a generated json, that is recreated every time we run a script. So you changes would be lost next time that happens. Could you please create a file with the same in the overrides folder and add the fix there? The definitions from both folders are then merged together so it's enough to only add the missing parameter.

{
  "search": {
    "url_params": {
      "error_trace": true
    }
  }
}

Thank you @yuliacech for your advice and expertise!

@vladpro25
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @vladpro25!
Tested locally and everything works great 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vladpro25

@vladpro25 vladpro25 merged commit b58445d into elastic:main Dec 13, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
…lastic#120290)

* Expose the error_trace parameter for completion

* Dev Tools Console: Expose the error_trace parameter for completion

* Dev Tools Console: Expose the error_trace parameter for completion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
…lastic#120290)

* Expose the error_trace parameter for completion

* Dev Tools Console: Expose the error_trace parameter for completion

* Dev Tools Console: Expose the error_trace parameter for completion

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev Tools Console: Expose the error_trace parameter for completion
6 participants