-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Tools Console: Expose the error_trace parameter for completion #120290
Conversation
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pinging @elastic/kibana-stack-management (Team:Stack Management) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vladpro25, thank you so much for working on this fix!
The file that you are updating is a generated json, that is recreated every time we run a script. So you changes would be lost next time that happens.
Could you please create a file with the same in the overrides
folder and add the fix there? The definitions from both folders are then merged together so it's enough to only add the missing parameter.
{
"search": {
"url_params": {
"error_trace": true
}
}
}
@elasticmachine merge upstream |
Thank you @yuliacech for your advice and expertise! |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @vladpro25!
Tested locally and everything works great 👍
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @vladpro25 |
…lastic#120290) * Expose the error_trace parameter for completion * Dev Tools Console: Expose the error_trace parameter for completion * Dev Tools Console: Expose the error_trace parameter for completion Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…lastic#120290) * Expose the error_trace parameter for completion * Dev Tools Console: Expose the error_trace parameter for completion * Dev Tools Console: Expose the error_trace parameter for completion Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes: #98904
Describe the issue:
Similar to the filter_path parameter, there is also a error_trace parameter in order to return full stack trace from Elasticsearch in case an exception is returned.
As this parameter is used a bit on error handling, it is quite tedious to look it up every time, so the user would like it to be available in developer tools requests by default.
Final result
The error_trace parameter was added by default in developer tools requests.
Confirmation