Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure saved search id is carried over to saved object #121082

Merged
merged 3 commits into from Dec 14, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #121009

This PR makes sure the saved search id is copied from the attributes of a by-value visualization into the newly created saved object on unlinking a panel from the dashboard.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure backport:skip This commit does not require backporting v8.1.0 labels Dec 13, 2021
@flash1293 flash1293 marked this pull request as ready for review December 13, 2021 16:00
@flash1293 flash1293 requested a review from a team as a code owner December 13, 2021 16:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested various scenarios with by value and by ref visualizations. The problem has been fixed and everything else seems to work as expected.

@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visualizations 37.8KB 37.9KB +52.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 4d4441c into elastic:main Dec 14, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Visualize][Dashboard] Linking a visualize embeddable that uses a saved search causes error
6 participants