Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dirty checking for changes to Time Series Visual Builder #12114

Merged
merged 1 commit into from Jun 12, 2017

Conversation

simianhacker
Copy link
Member

This PR changes the dirty checking from just the series to the entire panel. So now when the user makes changes to the panel options the applly button will activate.

@simianhacker simianhacker added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) review v5.5.0 v6.0.0 v6.0.0-alpha2 labels May 31, 2017
@simianhacker simianhacker requested a review from LeeDr May 31, 2017 23:10
@LeeDr LeeDr requested a review from bhavyarm June 2, 2017 15:23
@spalger spalger added the v5.6.0 label Jun 7, 2017
@simianhacker
Copy link
Member Author

@LeeDr Are you planning on reviewing this? or should I find someone else?

@bhavyarm
Copy link
Contributor

@simianhacker sorry for the delay. I forgot to update the PR.

Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simianhacker
Copy link
Member Author

Back ported to 5.5 with 63a4b6b
Back ported to 5.x with 7d59050

chrisronline pushed a commit to chrisronline/kibana that referenced this pull request Jun 14, 2017
stacey-gammon pushed a commit to stacey-gammon/kibana that referenced this pull request Jun 14, 2017
@simianhacker simianhacker deleted the auto-apply-for-all branch April 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix review v5.5.0 v5.6.0 v6.0.0-beta1 v6.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants