[Discover] Add kibana services provider for embeddable #121621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaanj
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
@elasticmachine merge upstream |
kertal
reviewed
Dec 20, 2021
There was a problem hiding this comment.
This PR fixes the bug 👍 tested and confirmed in Safari, MacOS. Could you add a functional test for it? we need to back port this. many thx. BTW about functional testing of the expand functionality, I'm currently working on making an existing test unflaky #107311
This test wouldn't cover the expand functionality on a dashboard, but it can be used as a template to not having to reinvent the wheel :)
|
@elasticmachine merge upstream |
dimaanj
added
the
technical debt
|
@elasticmachine merge upstream |
dimaanj
removed
the
technical debt
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
kertal
reviewed
Jan 10, 2022
kertal
approved these changes
Jan 10, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @dmitriynj |
kertal
added
the
auto-backport
💔 Some backports could not be created
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
dimaanj
added a commit
to dimaanj/kibana
that referenced
this pull request
Jan 11, 2022
* [Discover] add kibana services provider for embeddable * [Discover] add functional test * [Discover] fix functional test * [Discover] fix data grid test * [Discover] go to discover main page before each test * [Discover] remove redundant navigation to discover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f5aa068) # Conflicts: # src/plugins/discover/public/application/embeddable/saved_search_grid.tsx
This was referenced Jan 11, 2022
dimaanj
added a commit
to dimaanj/kibana
that referenced
this pull request
Jan 11, 2022
* [Discover] add kibana services provider for embeddable * [Discover] add functional test * [Discover] fix functional test * [Discover] fix data grid test * [Discover] go to discover main page before each test * [Discover] remove redundant navigation to discover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f5aa068) # Conflicts: # src/plugins/discover/public/application/embeddable/saved_search_grid.tsx
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* [Discover] add kibana services provider for embeddable * [Discover] add functional test * [Discover] fix functional test * [Discover] fix data grid test * [Discover] go to discover main page before each test * [Discover] remove redundant navigation to discover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
dimaanj
added a commit
that referenced
this pull request
Jan 13, 2022
#122702) * [Discover] Add kibana services provider for embeddable (#121621) * [Discover] add kibana services provider for embeddable * [Discover] add functional test * [Discover] fix functional test * [Discover] fix data grid test * [Discover] go to discover main page before each test * [Discover] remove redundant navigation to discover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f5aa068) # Conflicts: # src/plugins/discover/public/application/embeddable/saved_search_grid.tsx * [Discover] fix imports * [Discover] return data grid expand action * [Discover] fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
dimaanj
added a commit
that referenced
this pull request
Jan 13, 2022
… (#122701) * [Discover] Add kibana services provider for embeddable (#121621) * [Discover] add kibana services provider for embeddable * [Discover] add functional test * [Discover] fix functional test * [Discover] fix data grid test * [Discover] go to discover main page before each test * [Discover] remove redundant navigation to discover Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit f5aa068) # Conflicts: # src/plugins/discover/public/application/embeddable/saved_search_grid.tsx * [Discover] fix imports * [Discover] return data grid expand action * [Discover] fix functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #121183
This PR adds kibana services provider for embeddable.