[Security Solution][Endpoint] Artifacts event filter card on integration policy edit view #121879

ashokaditya · 2021-12-22T13:57:06Z

Summary

For each integration policy under Endpoint Security integration, this PR adds an artifact event filters summary card.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

academo · 2021-12-31T08:29:45Z

General advice: don't use the "wrapper" approach for this functionality if you can save it. It makes things more complicated than they should be. I'd rather have two separate components, one for the fleet "advance settings" and other for this specific view. I saw how the code got complex in trusted apps and in general you are only reusing one variable.

refs elastic/security-team/issues/2031

…ration fixes elastic/security-team/issues/2031

fixes elastic/security-team/issues/2031

refs elastic/pull/111708

elasticmachine · 2022-01-05T09:39:07Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

ashokaditya · 2022-01-05T09:42:34Z

...manager_integration/endpoint_package_custom_extension/components/exception_items_summary.tsx

 }>`
-  font-size: ${({ isSmall, theme }) => (isSmall ? theme.eui.euiFontSizeXS : 'innherit')};
-  font-weight: ${({ isSmall }) => (isSmall ? '1px' : 'innherit')};
+  font-size: ${({ isSmall, theme }) => (isSmall ? theme.eui.euiFontSizeXS : 'inherit')};
+  font-weight: ${({ isSmall }) => (isSmall ? '1px' : 'inherit')};


I missed this in an earlier review! 😅

dasansol92

Thanks for handling this! Left two small comments

dasansol92 · 2022-01-05T10:05:40Z

x-pack/plugins/security_solution/public/management/common/routing.ts

@@ -351,7 +351,7 @@ export const getPolicyDetailsArtifactsListPath = (
  )}`;
 };

-export const extractEventFiltetrsPageLocation = (
+export const extractEventFiltersPageLocation = (


...n/endpoint_package_custom_extension/components/fleet_integration_event_filters_card.test.tsx

dasansol92 · 2022-01-05T10:11:37Z

...n/endpoint_package_custom_extension/components/fleet_integration_event_filters_card.test.tsx

+      `/app/security/administration/policy/${policyId}/eventFilters`
+    );
+  });
+});


Can you add a test case for the error handling? A test that checks a toast is shown when there is an API error.

done 3bc3a04

review suggestion

...n/endpoint_package_custom_extension/components/fleet_integration_event_filters_card.test.tsx

paul-tavares

👍

ashokaditya · 2022-01-06T15:26:16Z

@elasticmachine merge upstream

…ion_policy_edit-2031

parkiino

Checked it out and it looks goood to meee 🐑 🚢

ashokaditya · 2022-01-06T18:38:54Z

@elasticmachine merge upstream

…ion_policy_edit-2031

kibana-ci · 2022-01-06T20:26:28Z

💛 Build succeeded, but was flaky

Test Failures

[job] [logs] Default CI Group #1 / APM API tests trial apm_mappings_only_8.0.0 fetching service anomalies with a trial license with ml jobs "before all" hook for "returns a 200 for a user with access to ML"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	2838	2839	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	4.6MB	4.6MB	+2.1KB

History

💔 Build #15992 failed 3bc3a04
💚 Build #15933 succeeded 43675ea
💚 Build #15850 succeeded 1c25b10
💛 Build #15686 was flaky 71778bc
💚 Build #15593 succeeded 5c6b490

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

kibanamachine · 2022-01-06T20:26:53Z

💔 Backport failed

The backport operation could not be completed due to the following error:
You must specify a valid Github repository

You can specify it via either:

Config file (recommended): ".backportrc.json". Read more: https://github.com/sqren/backport/blob/e119d71d6dc03cd061f6ad9b9a8b1cd995f98961/docs/configuration.md#project-config-backportrcjson
CLI: "--upstream elastic/kibana"

The backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 121879

…ion policy edit view (elastic#121879) * fix typo refs elastic/security-team/issues/2031 * Add artifact event filters card to policy edit view on endpoint integration fixes elastic/security-team/issues/2031 * add tests fixes elastic/security-team/issues/2031 * fix typo refs elastic/pull/111708 * use `eventFiltersListQueryHttpMock` instead review suggestion * add a test for verifying error toast review suggestion * fix tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

ashokaditya self-assigned this Dec 22, 2021

ashokaditya added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.1.0 release_note:feature Makes this part of the condensed release notes auto-backport Deprecated: Automatically backport this PR after it's merged labels Dec 22, 2021

ashokaditya force-pushed the task/olm-artifact_event_filter_card_integration_policy_edit-2031 branch 4 times, most recently from 1ba29a4 to 505ac94 Compare December 22, 2021 16:14

ashokaditya force-pushed the task/olm-artifact_event_filter_card_integration_policy_edit-2031 branch 2 times, most recently from 5c6b490 to 15de6c0 Compare January 4, 2022 14:33

ashokaditya added 4 commits January 5, 2022 10:38

fix typo

6a059c8

refs elastic/security-team/issues/2031

Add artifact event filters card to policy edit view on endpoint integ…

5d78e67

…ration fixes elastic/security-team/issues/2031

add tests

9858e56

fixes elastic/security-team/issues/2031

fix typo

1c25b10

refs elastic/pull/111708

ashokaditya force-pushed the task/olm-artifact_event_filter_card_integration_policy_edit-2031 branch from 8621eb9 to 1c25b10 Compare January 5, 2022 09:38

ashokaditya marked this pull request as ready for review January 5, 2022 09:39

ashokaditya requested a review from a team as a code owner January 5, 2022 09:39

ashokaditya requested review from pzl and paul-tavares January 5, 2022 09:39

ashokaditya commented Jan 5, 2022

View reviewed changes

dasansol92 reviewed Jan 5, 2022

View reviewed changes

ashokaditya added 2 commits January 5, 2022 16:45

use eventFiltersListQueryHttpMock instead

43675ea

review suggestion

add a test for verifying error toast

3bc3a04

review suggestion

ashokaditya force-pushed the task/olm-artifact_event_filter_card_integration_policy_edit-2031 branch from 659b71b to 3bc3a04 Compare January 5, 2022 19:05

ashokaditya commented Jan 6, 2022

View reviewed changes

...n/endpoint_package_custom_extension/components/fleet_integration_event_filters_card.test.tsx Outdated Show resolved Hide resolved

paul-tavares approved these changes Jan 6, 2022

View reviewed changes

fix tests

ef5911d

Merge branch 'main' into task/olm-artifact_event_filter_card_integrat…

dbd2242

…ion_policy_edit-2031

parkiino approved these changes Jan 6, 2022

View reviewed changes

ashokaditya enabled auto-merge (squash) January 6, 2022 18:38

Merge branch 'main' into task/olm-artifact_event_filter_card_integrat…

6b5c6ee

…ion_policy_edit-2031

ashokaditya merged commit 34d7ca6 into elastic:main Jan 6, 2022

kibanamachine added the backport:skip This commit does not require backporting label Jan 6, 2022

ashokaditya deleted the task/olm-artifact_event_filter_card_integration_policy_edit-2031 branch January 7, 2022 08:13

ashokaditya removed the auto-backport Deprecated: Automatically backport this PR after it's merged label Jan 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint] Artifacts event filter card on integration policy edit view #121879

[Security Solution][Endpoint] Artifacts event filter card on integration policy edit view #121879

ashokaditya commented Dec 22, 2021 •

edited

academo commented Dec 31, 2021

elasticmachine commented Jan 5, 2022

ashokaditya Jan 5, 2022

dasansol92 left a comment

dasansol92 Jan 5, 2022

dasansol92 Jan 5, 2022

ashokaditya Jan 5, 2022

paul-tavares left a comment

ashokaditya commented Jan 6, 2022

parkiino left a comment

ashokaditya commented Jan 6, 2022

kibana-ci commented Jan 6, 2022

kibanamachine commented Jan 6, 2022

[Security Solution][Endpoint] Artifacts event filter card on integration policy edit view #121879

[Security Solution][Endpoint] Artifacts event filter card on integration policy edit view #121879

Conversation

ashokaditya commented Dec 22, 2021 • edited

Summary

Checklist

academo commented Dec 31, 2021

elasticmachine commented Jan 5, 2022

ashokaditya Jan 5, 2022

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

dasansol92 Jan 5, 2022

Choose a reason for hiding this comment

dasansol92 Jan 5, 2022

Choose a reason for hiding this comment

ashokaditya Jan 5, 2022

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

ashokaditya commented Jan 6, 2022

parkiino left a comment

Choose a reason for hiding this comment

ashokaditya commented Jan 6, 2022

kibana-ci commented Jan 6, 2022

💛 Build succeeded, but was flaky

Test Failures

Metrics [docs]

Module Count

Async chunks

History

kibanamachine commented Jan 6, 2022

💔 Backport failed

ashokaditya commented Dec 22, 2021 •

edited