Replace node-uuid with uuid #12209
Merged
Replace node-uuid with uuid #12209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersmalley
approved these changes
Jun 6, 2017
spalger
pushed a commit
that referenced
this pull request
Jun 6, 2017
* replace node-uuid with uuid package * fix all the uuid call sites (cherry picked from commit 1ffa6df)
|
5.5/5.x: c32e765 |
|
Wait! I hadn't given my approval... |
|
You 💤 , you lose @simianhacker |
|
Yeah... except I was in the middle of figuring out why I was getting errors so I could check TSVB... Oh well. I guess we can fix it in QA |
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Jun 14, 2017
* replace node-uuid with uuid package * fix all the uuid call sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate a fair number of UUIDs in Kibana, and we've been using the wrong module for some time now.
node-uuidwas replaced withuuidsome time ago (years).This PR updates Kibana so it uses the right one. The major version changes in the package do not affect our use.
I noticed the warning when I was installing packages as part of #12025