Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps] fix Color ramp UI for percent of a top term in join layer is broken #122718

Merged
merged 3 commits into from Jan 14, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jan 11, 2022

Fixes #122674

#116366 caused the regression by returning the wrong value for TopTermPercentageField.supportsFieldMetaFromLocalData. TopTermPercentageField.supportsFieldMetaFromLocalData should return true when field is geojson source.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 auto-backport Deprecated: Automatically backport this PR after it's merged v8.1.0 labels Jan 11, 2022
@nreese nreese requested a review from a team as a code owner January 11, 2022 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally on Chrome and works 👍, thanks for the quick fix!

@nreese
Copy link
Contributor Author

nreese commented Jan 13, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.5MB 2.5MB +23.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit faa2afb into elastic:main Jan 14, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 14, 2022
…roken (elastic#122718)

* [maps] fix Color ramp UI for percent of a top term in join layer is broken

* add comments and make more explicit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit faa2afb)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 14, 2022
…roken (#122718) (#123041)

* [maps] fix Color ramp UI for percent of a top term in join layer is broken

* add comments and make more explicit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit faa2afb)

Co-authored-by: Nathan Reese <reese.nathan@gmail.com>
ogupte pushed a commit to ogupte/kibana that referenced this pull request Jan 28, 2022
…roken (elastic#122718)

* [maps] fix Color ramp UI for percent of a top term in join layer is broken

* add comments and make more explicit

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Color ramp UI for percent of a top term in join layer is broken
6 participants