Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Do not display add agent for managed policy in integration details #123160

Merged
merged 4 commits into from
Jan 18, 2022
Merged

[Fleet] Do not display add agent for managed policy in integration details #123160

merged 4 commits into from
Jan 18, 2022

Conversation

nchaulet
Copy link
Member

Description

Resolve #122298

Do not display the add agent button for managed policy

UI Changes

Managed policy

Screen Shot 2022-01-17 at 9 00 34 AM

Non managed policy

Screen Shot 2022-01-17 at 9 00 37 AM

@nchaulet nchaulet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated: Automatically backport this PR after it's merged v8.1.0 v7.17.0 labels Jan 17, 2022
@nchaulet nchaulet self-assigned this Jan 17, 2022
@nchaulet nchaulet requested a review from a team as a code owner January 17, 2022 14:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

kpollich
kpollich approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@kpollich kpollich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliaElastic
juliaElastic approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 644.1KB 644.1KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 52d4475 into elastic:main Jan 18, 2022
@nchaulet nchaulet deleted the fix-122298-do-not-allow-user-to-add-agent-managed-policy branch January 18, 2022 14:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 18, 2022
@nchaulet @kibanamachine
[Fleet] Do not display add agent for managed policy in integration de…
737c419 
…tails (elastic#123160)

(cherry picked from commit 52d4475)
@kibanamachine kibanamachine mentioned this pull request Jan 18, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 18, 2022
@nchaulet @kibanamachine
[Fleet] Do not display add agent for managed policy in integration de…
8e2fc48 
…tails (elastic#123160)

(cherry picked from commit 52d4475)
@kibanamachine kibanamachine mentioned this pull request Jan 18, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 18, 2022
@kibanamachine @nchaulet
[Fleet] Do not display add agent for managed policy in integration de…
7a628c0 
…tails (#123160) (#123231)

(cherry picked from commit 52d4475)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
kibanamachine added a commit that referenced this pull request Jan 18, 2022
@kibanamachine @nchaulet
[Fleet] Do not display add agent for managed policy in integration de…
276850e 
…tails (#123160) (#123232)

(cherry picked from commit 52d4475)

Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
ogupte pushed a commit to ogupte/kibana that referenced this pull request Jan 28, 2022
@nchaulet @ogupte
[Fleet] Do not display add agent for managed policy in integration de…
b70d17e 
…tails (elastic#123160)
@nchaulet nchaulet mentioned this pull request Jan 31, 2022
Merged
@dikshachauhan-qasource
Copy link

Hi @nchaulet

We have validated this on 8.0 rc2 BC4 and 7.17 released build and found it fixed.

  • Now, user is unable to install agent under Managed policy through Integrations tab.

Screenshot on 8.0:
image

Build details:

8.0: 
BUILD 49192
COMMIT 57ca5e139a33dd2eed927ce98d8231a1f217cd15
7.17:
BUILD 46534
COMMIT 60a9838d21b6420bbdb5a4d07099111b74c68ceb

Thanks
QAS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpollich kpollich kpollich approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@nchaulet nchaulet

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] User is able to install Fleet server using managed policy.
7 participants
@nchaulet @elasticmachine @kibana-ci @kibanamachine @dikshachauhan-qasource @kpollich @juliaElastic