[Stack monitoring] remove support for monitoring.cluster_alerts.allowedSpaces #123229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klacabane
added
backport-v8.0.0
release_note:deprecation
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
klacabane
changed the title
4 tasks
matschaffer
approved these changes
Jan 19, 2022
| @@ -149,7 +149,7 @@ | |||
| "signature": [ | |||
| "{ ui: { elasticsearch: ", | |||
| "MonitoringElasticsearchConfig", | |||
| "; enabled: boolean; container: Readonly<{} & { logstash: Readonly<{} & { enabled: boolean; }>; apm: Readonly<{} & { enabled: boolean; }>; elasticsearch: Readonly<{} & { enabled: boolean; }>; }>; logs: Readonly<{} & { index: string; }>; metricbeat: Readonly<{} & { index: string; }>; debug_mode: boolean; debug_log_path: string; ccs: Readonly<{} & { enabled: boolean; }>; max_bucket_size: number; min_interval_seconds: number; show_license_expiration: boolean; }; tests: Readonly<{} & { cloud_detector: Readonly<{} & { enabled: boolean; }>; }>; kibana: Readonly<{} & { collection: Readonly<{} & { interval: number; enabled: boolean; }>; }>; agent: Readonly<{} & { interval: string; }>; licensing: Readonly<{} & { api_polling_frequency: moment.Duration; }>; cluster_alerts: Readonly<{} & { enabled: boolean; allowedSpaces: string[]; email_notifications: Readonly<{} & { enabled: boolean; email_address: string; }>; }>; }" | |||
There was a problem hiding this comment.
Interesting how the field ends up in the API definition as well.
| @@ -58,7 +58,6 @@ export const configSchema = schema.object({ | |||
| }), | |||
| }), | |||
| cluster_alerts: schema.object({ | |||
| allowedSpaces: schema.arrayOf(schema.string(), { defaultValue: ['default'] }), | |||
There was a problem hiding this comment.
@smith mentioned we might want to keep this as an unused/deprecated value https://github.com/elastic/kibana/blob/6693ef371f887eca639b09c4c9b15701b4ebabd4/docs/developer/architecture/core/configuration-service.asciidoc#handle-plugin-configuration-deprecations
Though I think @jasonrhodes mentioned it wasn't actively used to begin with. Maybe fine to remove it directly.
There was a problem hiding this comment.
Flagged the setting as unused which sounds like a better ux
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @klacabane |
klacabane
added
the
auto-backport
💔 All backports failed
How to fixRe-run the backport manually: Questions ?Please refer to the Backport tool documentation |
klacabane
added a commit
to klacabane/kibana
that referenced
this pull request
Jan 25, 2022
…edSpaces (elastic#123229) * remove allowed space setting * set allowedSpaces as unused setting * mock unused function in deprecation tests Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 24f0425) # Conflicts: # api_docs/monitoring.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #120261
Remove support for monitoring.cluster_alerts.allowedSpaces configuration setting which is used during SM alert creation.
Testing
[2022-01-24T13:54:14.101+01:00][WARN ][config.deprecation] You no longer need to configure "monitoring.cluster_alerts.allowedSpaces".