Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoload react_components module #12338

Merged
merged 2 commits into from Jun 14, 2017
Merged

Autoload react_components module #12338

merged 2 commits into from Jun 14, 2017

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jun 14, 2017 •
edited

This module is required in order to use the confirm modal.

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. bug Fixes for quality problems that affect the customer experience chore labels Jun 14, 2017
@stacey-gammon
Copy link
Contributor

There are two other places that load that module. Now that it's in autoload, I'm thinking we might be able to get rid of the other two places?

screen shot 2017-06-14 at 1 12 10 pm

@cjcenizal
Copy link
Contributor Author

@stacey-gammon Done! Ready for your 👀 again.

stacey-gammon
stacey-gammon approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

kobelb
kobelb approved these changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@kobelb kobelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjcenizal cjcenizal merged commit ee5e442 into elastic:master Jun 14, 2017
@cjcenizal cjcenizal deleted the bug/autoload-react-components branch June 14, 2017 19:26
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2017
@cjcenizal
Autoload react_components module (elastic#12338)
65c4852 
* Autoload react_components module.
* Remove import of react_components from kibana plugin.
@cjcenizal cjcenizal mentioned this pull request Jun 14, 2017
Merged
cjcenizal added a commit that referenced this pull request Jun 14, 2017
@cjcenizal
Autoload react_components module (#12338) (#12348)
3a215e1 
* Autoload react_components module.
* Remove import of react_components from kibana plugin.
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 14, 2017
@cjcenizal
Autoload react_components module (elastic#12338)
8936327 
* Autoload react_components module.
* Remove import of react_components from kibana plugin.
@cjcenizal cjcenizal mentioned this pull request Jun 14, 2017
Merged
cjcenizal added a commit that referenced this pull request Jun 14, 2017
@cjcenizal
Autoload react_components module (#12338) (#12352)
762e155 
* Autoload react_components module.
* Remove import of react_components from kibana plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobelb kobelb kobelb approved these changes

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.5.0 v6.0.0-beta1 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cjcenizal @stacey-gammon @kobelb @epixa