[ML] Transforms: Fix editing retention policy without default value. #123450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui (:ml) |
pheyos
reviewed
Jan 20, 2022
pheyos
reviewed
Jan 20, 2022
|
Tested and confirmed the issue is fixed. Code change LGTM 🎉 |
qn895
approved these changes
Jan 20, 2022
|
@elasticmachine merge upstream |
|
@pheyos this one is ready for another look, updated the tests. |
pheyos
reviewed
Jan 24, 2022
There was a problem hiding this comment.
Test changes LGTM and I couldn't reproduce the linked issue with this fix anymore.
But I've noticed a different issue:
- Create a transform with source data that has more than 1 time field (e.g. the ecommerce sample data)
- Add a retention policy and don't use the first time field for the max age retention field (in the ecommerce example use
order_date) - Clone that transform
- => The wizard pre-fills the retention policy max age field with the wrong value (it seems to pick the first available entry and not the one saved in the transform - in the ecommerce example it picks
customer_birth_dateinstead of the configuredorder_date).
|
@pheyos Thanks for catching the cloning issue. When loading the wizard it didn't pick up the value provided by the config to be cloned but always fell back to the first available date field. Fixed and now covered by functional tests in f81c9e2. |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @walterra |
13 tasks
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 24, 2022
…lastic#123450) - Previously, a bug with how the form state would handle retention policy and populating the field select, a user could be blocked from setting the field or the form state wouldn't pick up the initial setting. - This is now fixed by setting hasNoInitialSelection to reflect the form set. If no retention policy had been set previously, the select dropdown will be empty until the user does a selection (which will then correctly update the to be updated transform config). - Functional tests have been updated to fail reflect the change and fail without the fix. - Fixed a cloning issue: When loading the wizard it didn't pick up the retention policy value provided by the config to be cloned but always fell back to the first available date field. (cherry picked from commit 1ecb42b)
walterra
added a commit
that referenced
this pull request
Jan 24, 2022
…123450) (#123602) - Previously, a bug with how the form state would handle retention policy and populating the field select, a user could be blocked from setting the field or the form state wouldn't pick up the initial setting. - This is now fixed by setting hasNoInitialSelection to reflect the form set. If no retention policy had been set previously, the select dropdown will be empty until the user does a selection (which will then correctly update the to be updated transform config). - Functional tests have been updated to fail reflect the change and fail without the fix. - Fixed a cloning issue: When loading the wizard it didn't pick up the retention policy value provided by the config to be cloned but always fell back to the first available date field. (cherry picked from commit 1ecb42b)
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Feb 17, 2022
…lastic#123450) - Previously, a bug with how the form state would handle retention policy and populating the field select, a user could be blocked from setting the field or the form state wouldn't pick up the initial setting. - This is now fixed by setting hasNoInitialSelection to reflect the form set. If no retention policy had been set previously, the select dropdown will be empty until the user does a selection (which will then correctly update the to be updated transform config). - Functional tests have been updated to fail reflect the change and fail without the fix. - Fixed a cloning issue: When loading the wizard it didn't pick up the retention policy value provided by the config to be cloned but always fell back to the first available date field. (cherry picked from commit 1ecb42b)
walterra
added a commit
that referenced
this pull request
Feb 17, 2022
…123450) (#125926) - Previously, a bug with how the form state would handle retention policy and populating the field select, a user could be blocked from setting the field or the form state wouldn't pick up the initial setting. - This is now fixed by setting hasNoInitialSelection to reflect the form set. If no retention policy had been set previously, the select dropdown will be empty until the user does a selection (which will then correctly update the to be updated transform config). - Functional tests have been updated to fail reflect the change and fail without the fix. - Fixed a cloning issue: When loading the wizard it didn't pick up the retention policy value provided by the config to be cloned but always fell back to the first available date field. (cherry picked from commit 1ecb42b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #122913.
hasNoInitialSelectionto reflect the form set. If no retention policy had been set previously, the select dropdown will be empty until the user does a selection (which will then correctly update the to be updated transform config).Checklist