-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Disable custom source_uri option on upgrade APIs by default #123464
Conversation
Pinging @elastic/fleet (Team:Fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review only. Are there any API tests in this area we could easily add one to?
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…lastic#123464) (cherry picked from commit 79ff195)
💔 Some backports could not be created
How to fixRe-run the backport manually:
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…lastic#123464) (cherry picked from commit 79ff195) # Conflicts: # x-pack/plugins/fleet/common/types/index.ts # x-pack/plugins/fleet/server/index.ts
Summary
Today we allow setting a
source_uri
field on the/api/fleet/agents/:id/upgrade
and/api/fleet/agents/bulk_upgrade
APIs which will tell Agents to download their upgrade from an alternative location other than artificats.elastic.coDisable this non-GA feature by default for now until better controls can be put in place. See thread starting around #100413 (comment) for more context.
This can be re-enabled for testing purposes by setting
xpack.fleet.developer.allowAgentUpgradeSourceUri
inkibana.yml