Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Disable custom source_uri option on upgrade APIs by default #123464

Merged
merged 4 commits into from
Jan 24, 2022

Conversation

joshdover
Copy link
Contributor

@joshdover joshdover commented Jan 20, 2022

Summary

Today we allow setting a source_uri field on the /api/fleet/agents/:id/upgrade and /api/fleet/agents/bulk_upgrade APIs which will tell Agents to download their upgrade from an alternative location other than artificats.elastic.co

Disable this non-GA feature by default for now until better controls can be put in place. See thread starting around #100413 (comment) for more context.

This can be re-enabled for testing purposes by setting xpack.fleet.developer.allowAgentUpgradeSourceUri in kibana.yml

@joshdover joshdover added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team auto-backport Deprecated: Automatically backport this PR after it's merged v8.1.0 v7.17.0 labels Jan 20, 2022
@joshdover joshdover requested a review from a team as a code owner January 20, 2022 14:57
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only. Are there any API tests in this area we could easily add one to?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 79ff195 into elastic:main Jan 24, 2022
@joshdover joshdover deleted the fleet/restrict-source-uri branch January 24, 2022 13:55
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 24, 2022
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.0
7.17 Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 123464

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

joshdover added a commit to joshdover/kibana that referenced this pull request Jan 24, 2022
…lastic#123464)

(cherry picked from commit 79ff195)

# Conflicts:
#	x-pack/plugins/fleet/common/types/index.ts
#	x-pack/plugins/fleet/server/index.ts
kibanamachine added a commit that referenced this pull request Jan 24, 2022
…123464) (#123600)

(cherry picked from commit 79ff195)

Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
joshdover added a commit that referenced this pull request Jan 24, 2022
…123464) (#123601)

(cherry picked from commit 79ff195)

# Conflicts:
#	x-pack/plugins/fleet/common/types/index.ts
#	x-pack/plugins/fleet/server/index.ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.17.0 v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants