Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Simplify browser router types #123549

Merged
merged 3 commits into from
Jan 24, 2022

Conversation

dgieselaar
Copy link
Member

This simplifies & speeds up browser router types by:

  • using a key-value pair for children so we don't have to use as const (and "unconst" it)
  • replacing extends clauses with many branches (which was necessary before TS 4.5) by spread + infer syntax

Improves language server responsiveness by 2x (~1s vs ~0.5s).

@dgieselaar dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated: Automatically backport this PR after it's merged v8.1.0 v8.2.0 labels Jan 23, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1184 1182 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/typed-react-router-config 78 83 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB -21.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/typed-react-router-config 0 1 +1
Unknown metric groups

API count

id before after diff
@kbn/typed-react-router-config 78 83 +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar marked this pull request as ready for review January 23, 2022 20:07
@dgieselaar dgieselaar requested review from a team as code owners January 23, 2022 20:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@dgieselaar dgieselaar enabled auto-merge (squash) January 23, 2022 20:07
@gbamparop gbamparop self-requested a review January 24, 2022 09:45
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these improvements!

@dgieselaar dgieselaar merged commit 429b252 into elastic:main Jan 24, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.2 The branch "8.2" is invalid or doesn't exist

How to fix

Re-run the backport manually:

node scripts/backport --pr 123549

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 26, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123549 or prevent reminders by adding the backport:skip label.

@dgieselaar dgieselaar added the backport:skip This commit does not require backporting label Jan 26, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants