Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tooltip for Surrounding documents #123890

Merged
merged 7 commits into from
Feb 16, 2022
Merged

Add tooltip for Surrounding documents #123890

merged 7 commits into from
Feb 16, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 27, 2022 •
edited
Loading

Summary

Adds a tooltip in the Document Explorer's Expanded Document flyout:

image

@lcawl lcawl added the WIP Work in progress label Jan 27, 2022
@lcawl lcawl added Feature:Discover Discover Application v8.1.0 and removed WIP Work in progress labels Jan 27, 2022
@lcawl lcawl requested a review from gchaps January 27, 2022 19:00
@lcawl lcawl marked this pull request as ready for review January 27, 2022 19:00
@lcawl lcawl requested a review from a team as a code owner January 27, 2022 19:00
@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Jan 27, 2022
kertal
kertal reviewed Jan 28, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx for providing users more info 👍 , just a question to @andreadelrio , are margins and vertical alignment fine?
Bildschirmfoto 2022-01-28 um 08 56 26

gchaps
gchaps approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM.

@kertal
Copy link
Member

kertal commented Feb 14, 2022

@elasticmachine merge upstream
dear @andreadelrio, could you have a look? many thx!

@lcawl lcawl added the v8.2.0 label Feb 14, 2022
@kertal kertal removed the v8.1.0 label Feb 14, 2022
@kertal kertal added this to PRs in Discover via automation Feb 14, 2022
andreadelrio
andreadelrio requested changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is looking a bit too tiny for me. I suggest we change both EuiButtonEmpty to size="s" and adding iconSize="s". Then we can remove the size prop from the EuiIconTip so that it uses the default size (m).

Frame 1

src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx Outdated Show resolved Hide resolved
src/plugins/discover/public/components/discover_grid/discover_grid_flyout.tsx Outdated Show resolved Hide resolved
lcawl and others added 2 commits February 14, 2022 14:26
@andreadelrio
Copy link
Contributor

@lcawl thanks for making those changes. You'll also need to update the EuiButtonEmpty for "Single document".

@lcawl
Copy link
Contributor Author

lcawl commented Feb 14, 2022

@lcawl thanks for making those changes. You'll also need to update the EuiButtonEmpty for "Single document".

Thanks @andreadelrio ! I've added another commit to hopefully address that as well: 72165b8

andreadelrio
andreadelrio approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@andreadelrio andreadelrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉. Thanks @lcawl and @gchaps for working on this.

@kertal kertal self-requested a review February 16, 2022 06:54
@kertal
Copy link
Member

kertal commented Feb 16, 2022

@elasticmachine merge upstream

kertal
kertal approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested in Firefox, Chrome, Safari. Works as expected, thanks for helping our users to quickly understand what surrounding documents do 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 335.5KB 336.0KB +504.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 82c2148 into elastic:main Feb 16, 2022
Discover automation moved this from PRs to Done Feb 16, 2022
@lcawl lcawl deleted the discover-help branch February 16, 2022 16:57
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 18, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123890 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 123890 or prevent reminders by adding the backport:skip label.

@kertal kertal added the backport:skip This commit does not require backporting label Feb 21, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 21, 2022
@davismcphee davismcphee mentioned this pull request Jan 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

@andreadelrio andreadelrio andreadelrio approved these changes

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
No open projects
Discover
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lcawl @kertal @andreadelrio @kibana-ci @kibanamachine @gchaps