New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CCS test for data view functionality. #124586

Merged

cuff-links merged 23 commits into elastic:main from cuff-links:CCS_Functional_Test_POC

Feb 24, 2022

Contributor

cuff-links commented Feb 3, 2022

Closes #124189


          Added CCS test for data view functionality.

762ca7c

cuff-links marked this pull request as draft

February 5, 2022 06:14

cuff-links added backport:skip release_note:skip Feature:Functional Testing test_ui_functional labels

cuff-links added 2 commits

February 7, 2022 21:25


          Changed how we are approaching the test. Just adding a remote to exer…

9a34f1a

…cise the CCS functionality.


          Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_…

c96fbf8

…Test_POC

cuff-links force-pushed the CCS_Functional_Test_POC branch from c52ee60 to 9a34f1a Compare

February 8, 2022 02:26

cuff-links added 4 commits

February 8, 2022 13:37


          Adjusted test to use correct port for remote cluster.

69c2f9f


          Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_…

623feed

…Test_POC


          Added and corrected config for the tests to be able to run.

6ae829c


          Changed test title.

cuff-links marked this pull request as ready for review

February 9, 2022 06:11

cuff-links added v8.2.0 v7.17.0 auto-backport and removed backport:skip labels

John Dorlus and others added 5 commits

February 9, 2022 11:37


          Added functional ccs suite to functional test runner script.

8e0883b


          Changed config.ts to config.js

03dcaba


          Moved es to before clause.

ba5ac7a


          Added await for an async call.

438df97


          Added await for an async call.

4b3bb5c

cuff-links requested review from spalger, stacey-gammon and LeeDr

February 10, 2022 03:23

Contributor Author

cuff-links commented Feb 10, 2022

@LeeDr @spalger @stacey-gammon We got this first CCS test passing. @LeeDr and I were talking about next steps regarding whether we would migrate our current discover tests (and any tests that could also use CCS) to use CCS instead of local search. Would we consider local search sufficiently tested if a CCS test passes? Should we duplicate the tests? If so, which benefit most from using CCS in automation?

Contributor

stacey-gammon commented Feb 11, 2022

Would we consider local search sufficiently tested if a CCS test passes?

I would, yes.

Should we duplicate the tests?

I wouldn't.

If so, which benefit most from using CCS in automation?

I would see if you could integrate CCS into the existing dashboard load tests. They cover a lot of searching, visualization types, embeddable, and filtering.


          Updated saved queries test to use CCS. One test is failing, all other…

611d0e9

…s are passing.

Contributor Author

cuff-links commented Feb 17, 2022

@LeeDr I was looking into this test failure. Turns out this test that we added is skipped in CI. Just so happened. We should get that fixed anything. #124990

cuff-links merged commit 1e16db4 into elastic:main

Contributor

kibanamachine commented Feb 24, 2022

💔 All backports failed

Status	Branch	Result
❌	7.17	Backport failed because of merge conflicts

How to fix

Re-run the backport manually:

node scripts/backport --pr 124586

Questions ?

Please refer to the Backport tool documentation

cuff-links mentioned this pull request

Failing test: Chrome UI Functional Tests.test/functional/apps/discover/_saved_queries·ts - discover app saved queries saved objects saved query selection "before all" hook for "should unselect saved query when navigating to a 'new'" #124990

Closed

kibanamachine added the backport missing label

Contributor

kibanamachine commented Feb 28, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124586 or prevent reminders by adding the backport:skip label.

1 similar comment

Contributor

kibanamachine commented Mar 1, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124586 or prevent reminders by adding the backport:skip label.

lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request


          Added CCS test for data view functionality. (elastic#124586)

f850b9c

* Added CCS test for data view functionality.

* Changed how we are approaching the test. Just adding a remote to exercise the CCS functionality.

* Adjusted test to use correct port for remote cluster.

* Added and corrected config for the tests to be able to run.

* Changed test title.

* Added functional ccs suite to functional test runner script.

* Changed config.ts to config.js

* Moved es to before clause.

* Added await for an async call.

* Added await for an async call.

* Updated saved queries test to use CCS. One test is failing, all others are passing.

* Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_Test_POC

* Fixed a reference.

* Removed the OSS tests since we created CCS versions of them.

* Removed tests from index file.

* Restored test files per comment with matthias.

* Did some cleanup of comments.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

LeeDr added v8.0.2 v8.1.0 labels

Contributor

kibanamachine commented Mar 3, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124586 or prevent reminders by adding the backport:skip label.

1 similar comment

Contributor

kibanamachine commented Mar 4, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124586 or prevent reminders by adding the backport:skip label.

LeeDr mentioned this pull request

CCS test isn't loading the ccs kbnArchive #126953

Closed

Contributor

kibanamachine commented Mar 7, 2022

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 124586 or prevent reminders by adding the backport:skip label.

kibanamachine mentioned this pull request

[ftr] implement support for accessing ES through CCS #126547

Merged

cuff-links mentioned this pull request

[8.1] Added CCS test for data view functionality. (#124586) #127092

Merged

cuff-links added a commit to cuff-links/kibana that referenced this pull request


          Added CCS test for data view functionality. (elastic#124586)

4c7f574

* Added CCS test for data view functionality.

* Changed how we are approaching the test. Just adding a remote to exercise the CCS functionality.

* Adjusted test to use correct port for remote cluster.

* Added and corrected config for the tests to be able to run.

* Changed test title.

* Added functional ccs suite to functional test runner script.

* Changed config.ts to config.js

* Moved es to before clause.

* Added await for an async call.

* Added await for an async call.

* Updated saved queries test to use CCS. One test is failing, all others are passing.

* Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_Test_POC

* Fixed a reference.

* Removed the OSS tests since we created CCS versions of them.

* Removed tests from index file.

* Restored test files per comment with matthias.

* Did some cleanup of comments.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1e16db4)

cuff-links mentioned this pull request

[7.17] Added CCS test for data view functionality. (#124586) #127093

Closed

cuff-links added a commit to cuff-links/kibana that referenced this pull request


          Added CCS test for data view functionality. (elastic#124586)

4a1d628

* Added CCS test for data view functionality.

* Changed how we are approaching the test. Just adding a remote to exercise the CCS functionality.

* Adjusted test to use correct port for remote cluster.

* Added and corrected config for the tests to be able to run.

* Changed test title.

* Added functional ccs suite to functional test runner script.

* Changed config.ts to config.js

* Moved es to before clause.

* Added await for an async call.

* Added await for an async call.

* Updated saved queries test to use CCS. One test is failing, all others are passing.

* Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_Test_POC

* Fixed a reference.

* Removed the OSS tests since we created CCS versions of them.

* Removed tests from index file.

* Restored test files per comment with matthias.

* Did some cleanup of comments.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1e16db4)

# Conflicts:
#	scripts/functional_tests.js

cuff-links removed the v8.0.2 label

Contributor

kibanamachine commented Mar 8, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

1 similar comment

Contributor

kibanamachine commented Mar 9, 2022

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

Contributor

stacey-gammon commented Mar 10, 2022

@cuff-links can you either backport or add a backport-skip label? I'm getting these reminder emails every day. :)

Contributor Author

cuff-links commented Mar 10, 2022

Will do. I will manually backport these once the PR that it depends on is backported.

cuff-links added the backport:skip label

kibanamachine removed the backport missing label

cuff-links added backport missing and removed auto-backport labels

kibanamachine removed the backport missing label

cuff-links pushed a commit that referenced this pull request


          [8.1] Added CCS test for data view functionality. (#124586) (#127092)

0ba2938

* Added CCS test for data view functionality. (#124586)

* Added CCS test for data view functionality.

* Changed how we are approaching the test. Just adding a remote to exercise the CCS functionality.

* Adjusted test to use correct port for remote cluster.

* Added and corrected config for the tests to be able to run.

* Changed test title.

* Added functional ccs suite to functional test runner script.

* Changed config.ts to config.js

* Moved es to before clause.

* Added await for an async call.

* Added await for an async call.

* Updated saved queries test to use CCS. One test is failing, all others are passing.

* Merge branch 'main' of github.com:elastic/kibana into CCS_Functional_Test_POC

* Fixed a reference.

* Removed the OSS tests since we created CCS versions of them.

* Removed tests from index file.

* Restored test files per comment with matthias.

* Did some cleanup of comments.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1e16db4)

* Fixed the core-migration version on the date_nested_ccs.json

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

cuff-links removed the v7.17.0 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment