Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stats permissions and use underscore instead of dash #12478

Merged
merged 1 commit into from Jun 26, 2017
Merged

Fix stats permissions and use underscore instead of dash #12478

merged 1 commit into from Jun 26, 2017

Conversation

stacey-gammon
Copy link
Contributor

  • Uses callWithRequest instead of callWithInternalUser
  • Changes dashes to underscores.

Fixes #12436

cc @epixa

@stacey-gammon
Copy link
Contributor Author

jenkins, test this

pickypg
pickypg approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending tests

tsullivan
tsullivan approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for picking up the snake case issue

@stacey-gammon stacey-gammon merged commit 929015b into elastic:master Jun 26, 2017
@epixa
Copy link
Contributor

epixa commented Jun 26, 2017

Awesome! Thanks for the quick turnaround on this

@jimgoodwin jimgoodwin added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:fix labels Jul 25, 2017
@stacey-gammon stacey-gammon deleted the fix/stats-api-permissions branch October 24, 2017 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

@pickypg pickypg pickypg approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stacey-gammon @epixa @tsullivan @pickypg @jimgoodwin