Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] Provide services to set context for recovered alerts #124972
[Alerting] Provide services to set context for recovered alerts #124972
Changes from 31 commits
72255bb
93082d6
5875e52
c254b9d
4b0ef8b
18ed715
6a7e256
a4a56a6
a5c2506
be68324
ba6a84f
f0046f2
41e75cf
d6ed52b
cbc8402
98fd000
3e002aa
35be5b6
fe49c49
5754075
5bb918b
8e585fe
e6e85f3
002f94b
3bd343b
3666f6c
61c6b77
50bbc78
fbe5973
3b4753b
9365756
fb54b5b
30d3f51
23234e6
b857955
f1f1469
31e70c9
18bf52f
9372b31
afe0c45
1a5df73
7e1d246
f22c83e
181657d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonrhodes This is the PR for providing the ability to set context on recovered alerts. Based on your feedback in the RFC, this is what I've settled on for actually setting the context. Instead of getting a list of recovered alerts ids and using a utility function to set context using the ID string, this returns a list of alerts, that you then call
setContext()
on.We had also talked about changing
scheduleActions()
for active alert to something clearer likescheduleActionsAndSetContext()
orscheduleAction().setContext()
, which is not addressed in this PR but it would be a straightforward change if we wanted to do it in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!!!