Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Update canvas function docs to match in app and vice versa #125259

Merged
merged 8 commits into from
Mar 1, 2022
Merged

[Canvas] Update canvas function docs to match in app and vice versa #125259

merged 8 commits into from
Mar 1, 2022

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Feb 10, 2022

This is an update to the Canvas function docs via running the function generator.

Had to add a few new functions to the generator and make some changes to in app text to bring in updates that were made to only the functions doc.

@crob611 crob611 requested review from a team as code owners February 10, 2022 15:23
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Feb 10, 2022
@crob611 crob611 added Feature:Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@crob611 crob611 added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v8.1.0 v8.2.0 labels Feb 10, 2022
ppisljar
ppisljar approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

cqliu1
cqliu1 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@cqliu1 cqliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one edit for the help text for mathColumn. All the other updates LGTM 👍

src/plugins/expressions/common/expression_functions/specs/math_column.ts Outdated Show resolved Hide resolved
src/plugins/expressions/common/expression_functions/specs/math_column.ts Outdated Show resolved Hide resolved
KOTungseth and others added 2 commits February 24, 2022 16:10
@KOTungseth @cqliu1
Update src/plugins/expressions/common/expression_functions/specs/math…
1dfb6b4 
…_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
@KOTungseth @cqliu1
Update src/plugins/expressions/common/expression_functions/specs/math…
c34666a 
…_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
@KOTungseth
Copy link
Contributor

@elasticmachine merge upstream

@KOTungseth
Copy link
Contributor

@elasticmachine merge upstream

@KOTungseth
Copy link
Contributor

jenkins, test this

@KOTungseth KOTungseth closed this Feb 28, 2022
@KOTungseth KOTungseth reopened this Feb 28, 2022
@crob611
Copy link
Contributor Author

crob611 commented Mar 1, 2022

@elasticmachine merge upstream

@crob611
Copy link
Contributor Author

crob611 commented Mar 1, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.0MB 1.0MB +89.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 87.5KB 87.5KB +25.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @KOTungseth

@crob611 crob611 added the auto-backport Deprecated: Automatically backport this PR after it's merged label Mar 1, 2022
@crob611 crob611 merged commit 933f43d into elastic:main Mar 1, 2022
@kibanamachine kibanamachine mentioned this pull request Mar 1, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 1, 2022
@kibanamachine
[Canvas] Update canvas function docs to match in app and vice versa (e…
b8c9c3e 
…lastic#125259)

* Update canvas function docs to match in app and vice versa

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Fix translations

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 933f43d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Mar 1, 2022
@kibanamachine
[Canvas] Update canvas function docs to match in app and vice versa (#…
a90d0e5 
…125259) (#126646)

* Update canvas function docs to match in app and vice versa

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Fix translations

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 933f43d)

Co-authored-by: Corey Robertson <corey.robertson@elastic.co>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@KOTungseth @cqliu1
@kibanamachine @lucasfcosta
[Canvas] Update canvas function docs to match in app and vice versa (e…
c7295b0 
…lastic#125259)

* Update canvas function docs to match in app and vice versa

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Fix translations

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@KOTungseth @cqliu1
@kibanamachine @lucasfcosta
[Canvas] Update canvas function docs to match in app and vice versa (e…
869d5ee 
…lastic#125259)

* Update canvas function docs to match in app and vice versa

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Update src/plugins/expressions/common/expression_functions/specs/math_column.ts

Co-authored-by: Catherine Liu <catherineqliu@outlook.com>

* Fix translations

Co-authored-by: Kaarina Tungseth <kaarina.tungseth@elastic.co>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqliu1 cqliu1 cqliu1 approved these changes

@ppisljar ppisljar ppisljar approved these changes

Assignees

@KOTungseth KOTungseth

Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Canvas Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@crob611 @elasticmachine @KOTungseth @kibana-ci @kibanamachine @cqliu1 @ppisljar