Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix Trained Model stats and pipelines tab #125382

Merged
merged 6 commits into from
Feb 11, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Feb 11, 2022

Summary

Part of #117501

  • Fixes the Stats tab content
  • Fixes the Pipelines tab for ML viewer
  • Adds functional tests for Trained Models rows expansion

Checklist

@darnautov darnautov added :ml test_ui_functional release_note:skip Skip the PR/issue when compiling release notes v8.1.0 Team:ML Team label for ML (also use :ml) v8.2.0 labels Feb 11, 2022
@darnautov darnautov requested a review from a team as a code owner February 11, 2022 14:53
@darnautov darnautov self-assigned this Feb 11, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to add extra checks for the actual contents of the tabs in the expanded row, but this LGTM as a first step.

@darnautov darnautov added the auto-backport Deprecated: Automatically backport this PR after it's merged label Feb 11, 2022
@darnautov darnautov changed the title [ML] Functional tests for Trained Models details [ML] Fix Trained Model stats and pipelines tab Feb 11, 2022
@darnautov darnautov enabled auto-merge (squash) February 11, 2022 17:05
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Test Failures

  • [job] [logs] Default CI Group #15 / machine learning model management trained models for ML user with read-only access renders expanded row content correctly for model with pipelines

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.5MB 3.5MB +1.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit 67fb388 into elastic:main Feb 11, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.1
8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 11, 2022
(cherry picked from commit 67fb388)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 11, 2022
(cherry picked from commit 67fb388)

Co-authored-by: Dima Arnautov <dmitrii.arnautov@elastic.co>
@darnautov darnautov deleted the ml-trained-models-details-tests branch February 14, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged :ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants