Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing issue with expressions pending #125520

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fixing issue with expressions pending #125520

merged 1 commit into from
Feb 14, 2022

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Feb 14, 2022 •
edited
Loading

Summary

resolves #123030

Expressions didn't correctly return the pending state when using partial results

Checklist

Delete any items that are not applicable to this PR.

@ppisljar ppisljar requested a review from a team as a code owner February 14, 2022 14:40
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Feb 14, 2022
@ppisljar ppisljar added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Feb 14, 2022
dokmic
dokmic approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job in covering the edge case with a unit test 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 87.2KB 87.2KB +33.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ppisljar ppisljar merged commit cc74733 into elastic:main Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokmic dokmic dokmic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] bsearch not aborted after changing the layers
3 participants
@ppisljar @kibana-ci @dokmic