[Security Solution] Update hover actions css selector to re-hide default cell actions #126551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqualters-elastic
added
bug
janmonschke
approved these changes
Mar 1, 2022
michaelolo24
approved these changes
Mar 1, 2022
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kqualters-elastic
added
backport:skip
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 8, 2022
…ult cell actions (elastic#126551) * Update hover actions css selector to re-hide default cell actions * Use better selector for expand icon
lucasfcosta
pushed a commit
to lucasfcosta/kibana
that referenced
this pull request
Mar 8, 2022
…ult cell actions (elastic#126551) * Update hover actions css selector to re-hide default cell actions * Use better selector for expand icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A recent upgrade to eui #125023 caused the css selector used by security solution to hide built in row cell hover actions https://github.com/elastic/kibana/blob/main/x-pack/plugins/security_solution/public/common/components/page/index.tsx#L38 to break, this pr updates the selector so that they are once again hidden. Can probably delete this code once elastic/eui#5132 is implemented.
Before:
After:
