Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Provide datatable utility functions #126572

Merged
merged 6 commits into from
Mar 2, 2022
Merged

[Data] Provide datatable utility functions #126572

merged 6 commits into from
Mar 2, 2022

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented Mar 1, 2022

Summary

Resolves #78745.

Checklist

For maintainers

@dokmic dokmic added review Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppServicesSv release_note:skip Skip the PR/issue when compiling release notes v8.2.0 labels Mar 1, 2022
@dokmic dokmic force-pushed the feature/78745 branch 2 times, most recently from adf6fe9 to 15c85ad Compare March 1, 2022 16:17
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 531 532 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2796 2819 +23

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
data 26 27 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 452.4KB 453.0KB +692.0B
Unknown metric groups

API count

id before after diff
data 3393 3418 +25

References to deprecated APIs

id before after diff
data 484 476 -8

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic marked this pull request as ready for review March 1, 2022 20:40
@dokmic dokmic requested a review from a team as a code owner March 1, 2022 20:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

ppisljar
ppisljar approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@dokmic dokmic merged commit 12f42e0 into elastic:main Mar 2, 2022
@dokmic dokmic deleted the feature/78745 branch March 2, 2022 12:25
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126572 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 4, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 126572 or prevent reminders by adding the backport:skip label.

@ppisljar ppisljar added the backport:skip This commit does not require backporting label Mar 7, 2022
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 7, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@dokmic @lucasfcosta
[Data] Provide datatable utility functions (elastic#126572)
e098615 
* Extract datatable utilities into a separate service
* Add getField utility function
* Add getFieldFormat utility function
* Add field format setter utility functions
* Add data view field setter utility functions
* Add getInterval utility function
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 8, 2022
@dokmic @lucasfcosta
[Data] Provide datatable utility functions (elastic#126572)
26ece04 
* Extract datatable utilities into a separate service
* Add getField utility function
* Add getFieldFormat utility function
* Add field format setter utility functions
* Add data view field setter utility functions
* Add getInterval utility function
@dokmic dokmic mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes review v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Expressions] datatable utility functions
5 participants
@dokmic @kibana-ci @elasticmachine @kibanamachine @ppisljar