Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds missing monitoring.cluster_alerts.email_notifications.email_address monitoring setting #126826

Merged
merged 4 commits into from
Mar 9, 2022

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Mar 3, 2022

Summary

Adds the monitoring.cluster_alerts.email_notifications.email_address settings to the Monitoring settings in Kibana page.

Since monitoring.cluster_alerts.email_notifications.email_address and monitoring.cluster_alerts.email_notifications.enabled apply to different versions, opened #127323 to address monitoring.cluster_alerts.email_notifications.enabled.

[skip-ci]

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@neptunian
Copy link
Contributor

What versions to these settings apply to? I added back to 7.6.0. If I need to backport to 7.5.0 and earlier, add the applicable versions.

monitoring.cluster_alerts.email_notifications.email_address was added in 6.5.0

I can't find when monitoring.cluster_alerts.email_notifications.enabled but I imagine it would be linked to whenever Watcher alerts were introduced into Monitoring. @chrisronline Do you know how I could figure that out? I can't find enough history to figure that out.

I added the In 9.0 and later, this setting will no longer be supported. deprecation note, but I am unsure about the 9.0 bit. We always add the version we plan to permanently remove the setting. If 9.0 is incorrect, which version is correct?

Is there any reason we can't remove it in the next release, say 8.2? With "make it minor" do we need to wait?

@neptunian
Copy link
Contributor

Chris helped me find some history so here are the versions when each was introduced:

monitoring.cluster_alerts.email_notifications.email_address was added in 6.5.0

monitoring.cluster_alerts.email_notifications.enabled was added in 6.0.0

@neptunian
Copy link
Contributor

Also, these stopped being used at 7.11 when ES watches were removed. So we can mark them as deprecated since 7.11.

@KOTungseth KOTungseth added the auto-backport Deprecated: Automatically backport this PR after it's merged label Mar 8, 2022
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 9, 2022
…ail_address` monitoring setting (elastic#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)
KOTungseth added a commit that referenced this pull request Mar 9, 2022
…ions.email_address` monitoring setting (#126826) (#127353)

* [DOCS] Adds missing `monitoring.cluster_alerts.email_notifications.email_address` monitoring setting (#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

* Removes deprecation message for unsupported version
KOTungseth added a commit that referenced this pull request Mar 10, 2022
…ions.email_address` monitoring setting (#126826) (#127351)

* [DOCS] Adds missing `monitoring.cluster_alerts.email_notifications.email_address` monitoring setting (#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

* Removes deprecation message for unsupported version

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ons.email_address` monitoring setting (#126826) (#127358)

* [DOCS] Adds missing `monitoring.cluster_alerts.email_notifications.email_address` monitoring setting (#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

* Removes deprecation message

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127368)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127367)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127366)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127365)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127364)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127362)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127361)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127360)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ail_address` monitoring setting (#126826) (#127359)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Mar 10, 2022
…ions.email_address` monitoring setting (#126826) (#127357)

* [DOCS] Adds missing `monitoring.cluster_alerts.email_notifications.email_address` monitoring setting (#126826)

* [DOCS] Adds missing deprecated monitoring settings

* Review comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 0bc7a2e)

* Removes deprecation message

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants