Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Remove temporal public methods from the cases plugin #127248

Merged
merged 1 commit into from
Mar 9, 2022
Merged

[Cases] Remove temporal public methods from the cases plugin #127248

merged 1 commit into from
Mar 9, 2022

Conversation

academo
Copy link
Contributor

@academo academo commented Mar 9, 2022

Summary

Epic: #123183

Follow up to #127003

Closes: #127124

This is the final PR to close the epic. It removes old public methods from the cases plugin that are not longer in use and not required by other plugins.

No business logic or UI is modified by this PR.

@academo academo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.2.0 labels Mar 9, 2022
@academo academo requested a review from a team as a code owner March 9, 2022 08:32
@academo academo self-assigned this Mar 9, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@academo academo enabled auto-merge (squash) March 9, 2022 08:35
peteharverson
peteharverson approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
cases 61 57 -4

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 84.3KB 84.2KB -73.0B
Unknown metric groups

API count

id before after diff
cases 84 80 -4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @academo

@academo academo merged commit b20a364 into elastic:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@cnasikas cnasikas cnasikas approved these changes

Assignees

@academo academo

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Remove deprecated APIs from the cases plugin.ts API
5 participants
@academo @elasticmachine @kibana-ci @peteharverson @cnasikas