Move eslint-config-kibana into core #12725
Conversation
[no-unused-vars]: Disallow declaration of variables that are not used in the code.
Bump to 0.1.0.
upgrade deps in preperation for babel6 transition
This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes
Disallow using 'context' in tests
* update deps * include eslint-plugin-import
* reorganize existing rules into groups * defreference eslint-plugin-import "recommended" config Based on https://github.com/benmosher/eslint-plugin-import/blob/ea9c92c7324473ef303ac76b127e17af2becd2ee/config/recommended.js
|
I emphatically support moving our package dependencies into Kibana proper. Every time I encounter code we've written that is important for the development or function of Kibana that I need to go track down in a separate repo, I die a little inside. |
kimjoar
force-pushed
the
eslint-config-kibana-into-core
branch
from
ebb2d95
to
4fbd3f2
Compare
|
@kjbekkelund Could you talk a little more about why we are still housing this as a "package" inside of a Is there a problem with just storing the |
|
@cjcenizal My goal here is purely pulling in external Kibana-related OSS repos that I feel should live in the main repo instead, so we can handle both issues and PRs in one place. I don't see the value in multiple repos for this stuff. This PR is not exploring better setups for our eslint stuff, that feels like something we should do in a follow-up PR. Re |
|
(I think one reason |
|
There's a tiny bit of explanation in the readme in the packages folder, though not specific to eslint stuff, just the thinking around |
|
Ah, I forgot about X-Pack! Thanks for the explanation, this makes sense. |
|
Btw, I was thinking about waiting with merging this until after ff, just so I'm 100% sure I don't break anything on something that's not important for 6.0. Feels like there's already so many things happening right now (and things breaking). Let me know if #12810 is essential in the short-term, then I can merge this asap instead of waiting. |
|
@kjbekkelund I think we're OK. I was actually thinking the same thing... better to wait until after FF for this kind of stuff. :) |
* Initial commit * added actual config * version 0.0.1 * version 0.0.2 * [no-const-assign] Disallow assignment to const http://eslint.org/docs/rules/no-const-assign * [no-redeclare] Disallow redeclaring variables http://eslint.org/docs/rules/no-redeclare * version 0.0.3 * [no-unused-vars]: Disallow declaration of variables that are not used in the code. * Bump to 0.1.0. * upgrade deps in preperation for babel6 transition * 0.2.0-alpha1 * use yaml for readability * 0.2.0 * update/pin peed dependency versions * 0.2.1 * [quotes] allow template literals This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes * 0.2.2 * add object-curly-spacing and no-global-assign rules * sort .eslintrc.yaml rules * 0.3.0 * add basic react support * 0.4.0 * Disallow using 'context' in tests * 0.5.0 * move from .eslintrc.yaml to .eslintrc.js without .json generation (#6) * Implement import plugin (#7) * update deps * include eslint-plugin-import * Dereference import config (#8) * reorganize existing rules into groups * defreference eslint-plugin-import "recommended" config Based on https://github.com/benmosher/eslint-plugin-import/blob/ea9c92c7324473ef303ac76b127e17af2becd2ee/config/recommended.js * 0.6.0 * set environment info for import rule * 0.6.1 * update peerDependencies * 0.7.0 * Move eslint-config-kibana into packages directory
* Initial commit * added actual config * version 0.0.1 * version 0.0.2 * [no-const-assign] Disallow assignment to const http://eslint.org/docs/rules/no-const-assign * [no-redeclare] Disallow redeclaring variables http://eslint.org/docs/rules/no-redeclare * version 0.0.3 * [no-unused-vars]: Disallow declaration of variables that are not used in the code. * Bump to 0.1.0. * upgrade deps in preperation for babel6 transition * 0.2.0-alpha1 * use yaml for readability * 0.2.0 * update/pin peed dependency versions * 0.2.1 * [quotes] allow template literals This allows eslint to validate this rule from the styleguide: https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#use-template-strings-to-avoid-escaping-single-quotes * 0.2.2 * add object-curly-spacing and no-global-assign rules * sort .eslintrc.yaml rules * 0.3.0 * add basic react support * 0.4.0 * Disallow using 'context' in tests * 0.5.0 * move from .eslintrc.yaml to .eslintrc.js without .json generation (#6) * Implement import plugin (#7) * update deps * include eslint-plugin-import * Dereference import config (#8) * reorganize existing rules into groups * defreference eslint-plugin-import "recommended" config Based on https://github.com/benmosher/eslint-plugin-import/blob/ea9c92c7324473ef303ac76b127e17af2becd2ee/config/recommended.js * 0.6.0 * set environment info for import rule * 0.6.1 * update peerDependencies * 0.7.0 * Move eslint-config-kibana into packages directory
I mentioned this a while ago and people seemed open to the idea. Everything stays the same as before (e.g. same npm publish flow), it's just that we can now PR against this repo instead of having a separate repo that no one remembers to check.
/cc @epixa, @spalger