Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Connect button now displays correct copy #127291

Merged
merged 3 commits into from
Mar 9, 2022
Merged

[Workplace Search] Connect button now displays correct copy #127291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31247b3
[Workplace Search] Connect button now displays correct copy
sphilipse Mar 9, 2022
cf171de
Remove unused import
sphilipse Mar 9, 2022
b445d2e
Merge branch 'main' into connectors-connect-button
kibanamachine Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .../workplace_search/views/content_sources/components/add_source/configured_sources_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ import {
EuiToolTip,
} from '@elastic/eui';

import { i18n } from '@kbn/i18n';

import { EuiButtonEmptyTo } from '../../../../../shared/react_router_helpers';
import { SourceIcon } from '../../../../components/shared/source_icon';
import { getAddPath, getSourcesPath } from '../../../../routes';
Expand All @@ -29,7 +31,6 @@ import { hasMultipleConnectorOptions } from '../../../../utils';
import {
CONFIGURED_SOURCES_LIST_UNCONNECTED_TOOLTIP,
CONFIGURED_SOURCES_LIST_ACCOUNT_ONLY_TOOLTIP,
CONFIGURED_SOURCES_CONNECT_BUTTON,
CONFIGURED_SOURCES_EMPTY_STATE,
CONFIGURED_SOURCES_TITLE,
CONFIGURED_SOURCES_EMPTY_BODY,
Expand Down Expand Up @@ -112,7 +113,19 @@ export const ConfiguredSourcesList: React.FC<ConfiguredSourcesProps> = ({
hasMultipleConnectorOptions(sourceData) ? '' : 'connect'
}`}
>
{CONFIGURED_SOURCES_CONNECT_BUTTON}
{!connected
sphilipse marked this conversation as resolved.
Show resolved Hide resolved
? i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.contentSource.configuredSources.connectButton',
{
defaultMessage: 'Connect',
}
)
: i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.contentSource.configuredSources.connectAnotherButton',
{
defaultMessage: 'Connect another',
}
)}
</EuiButtonEmptyTo>
)) || (
<EuiButtonEmpty className="eui-fullWidth" isDisabled>
Expand Down
7 changes: 0 additions & 7 deletions ...ic/applications/workplace_search/views/content_sources/components/add_source/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,13 +223,6 @@ export const CONFIGURED_SOURCES_LIST_ACCOUNT_ONLY_TOOLTIP = i18n.translate(
}
);

export const CONFIGURED_SOURCES_CONNECT_BUTTON = i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.contentSource.configuredSources.connectButton',
sphilipse marked this conversation as resolved.
Show resolved Hide resolved
{
defaultMessage: 'Connect another',
}
);

export const CONFIGURED_SOURCES_EMPTY_STATE = i18n.translate(
'xpack.enterpriseSearch.workplaceSearch.contentSource.configuredSources.emptyState',
{
Expand Down