Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Restore operation auto switch based on field type #127861

Merged
merged 5 commits into from Mar 17, 2022

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Mar 16, 2022

Summary

Fixes #127258

This PR restores a previous Lens behaviour when having a single field in Top values which wasn't supported: before multi terms the panel would automatically switch to a supported operation.

While investigating this change I've noticed that the field_select logic was relying on the assumption fieldName === displayName, which was not true. So I've also fixed this bug (notice timestampLabel for the timestamp field):

op_switch

To test:

  1. create a top values with one string field , the switch to date => it should switch to date histogram operation
  2. create a top values with multiple string field , the switch to date any field input => it should NOT switch to date , rather show an error histogram operation
  3. edit a date field label with a custom label, the repeat 1 and 2

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:skip This commit does not require backporting v8.2.0 labels Mar 16, 2022
@dej611 dej611 marked this pull request as ready for review March 16, 2022 13:31
@dej611 dej611 requested a review from a team as a code owner March 16, 2022 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a problem, took care of that. Approving as it works fine otherwise

// in single field mode, allow the automatic switch of the function to
// the most appropriate one
if (fields.length === 1) {
const newFieldOp = operationSupportMatrix.operationByField[sourcefield]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't just check for the first op, but whether terms is in the list or not. Right now switching to a number field while in "Top values" will switch to "Intervals" even though top values on a number field is a valid thing to do

@flash1293 flash1293 enabled auto-merge (squash) March 17, 2022 10:12
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +237.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 279bdfa into elastic:main Mar 17, 2022
ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request Mar 17, 2022
)

* 🐛 Restore date_histogram auto switch from top values + bug with displayName

* Fix case

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Picking a date field in Top values single mode should automatically switch to Date histogram
5 participants