Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soc dashboard - UI #128087

Merged
merged 65 commits into from
Apr 22, 2022
Merged

Soc dashboard - UI #128087

merged 65 commits into from
Apr 22, 2022

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Mar 18, 2022

Summary

#127649

This UI is to render donut charts with alerts by status (mock) data.
It shows an empty donut if a bucket is missing:

Kapture.2022-04-08.at.02.36.18.mp4

Screenshot 2022-04-08 at 02 34 01

Screenshot 2022-04-08 at 02 24 48

Screenshot 2022-04-14 at 16 55 25

Delete any items that are not applicable to this PR.

@angorayc angorayc changed the title Soc dashboard Soc dashboard - UI Mar 18, 2022
@angorayc angorayc marked this pull request as ready for review April 6, 2022 08:36
@angorayc angorayc requested a review from a team as a code owner April 6, 2022 08:36
@angorayc angorayc added backport:skip This commit does not require backporting Team:Threat Hunting Security Solution Threat Hunting Team release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Explore v8.3.0 labels Apr 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc
Copy link
Contributor Author

/oblt-deploy

@@ -17,7 +17,7 @@ export const allowedExperimentalValues = Object.freeze({
tGridEventRenderedViewEnabled: true,
excludePoliciesInFilterEnabled: false,
usersEnabled: true,
detectionResponseEnabled: false,
detectionResponseEnabled: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this merge to main as true? Should the feature still be hidden or am I misunderstanding what this is for?

Copy link
Contributor Author

@angorayc angorayc Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, it should be false, enabled it for deploying to cloud instance for design review, will remember to disable that

Copy link
Contributor

@jamster10 jamster10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge :D

angorayc and others added 4 commits April 21, 2022 01:08
@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Thank you @angorayc, great work! the donut chart has been hard to tame.

Copy link

@merilmathew merilmathew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given feedback on spacing, alignment and font sizes.

@angorayc
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 2756 2766 +10

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.8MB 4.8MB +11.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@angorayc angorayc merged commit 0073a06 into elastic:main Apr 22, 2022
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
* init pie chart

* styling

* donut card

* styling

* parser

* wording

* unit tests

* disable detectionResponse feature flag

* rename props

* add detection_response folder

* add query hook

* disable detectionResponse

* alerts button and count

* toggle query

* fix unit tests

* disable dashboard

* fillColor

* disable dashboard

* fix legends

* detectionResponseEnabled

* review

* rm old tests

* review

* fix types

* legend

* rename

* rm i18n keys

* unit tests

* update i18n keys

* add unit tests

* fix unit tests

* review

* review

* styling

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* styling

* styling

* useEuiTheme

* useEuiTheme

* enable feature flag

* disable flag

* enable dashboard

* disable dashboard

* Update x-pack/plugins/security_solution/public/common/components/charts/donutchart.tsx

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

* styling

* styling

* unit tests

* unit tests

* unit test

* unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
* init pie chart

* styling

* donut card

* styling

* parser

* wording

* unit tests

* disable detectionResponse feature flag

* rename props

* add detection_response folder

* add query hook

* disable detectionResponse

* alerts button and count

* toggle query

* fix unit tests

* disable dashboard

* fillColor

* disable dashboard

* fix legends

* detectionResponseEnabled

* review

* rm old tests

* review

* fix types

* legend

* rename

* rm i18n keys

* unit tests

* update i18n keys

* add unit tests

* fix unit tests

* review

* review

* styling

* [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix'

* styling

* styling

* useEuiTheme

* useEuiTheme

* enable feature flag

* disable flag

* enable dashboard

* disable dashboard

* Update x-pack/plugins/security_solution/public/common/components/charts/donutchart.tsx

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>

* styling

* styling

* unit tests

* unit tests

* unit test

* unit tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants