-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Show a fallback empty message when no results are found #128754
Conversation
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
...lication/main/components/no_results/no_results_suggestions/no_results_suggestion_default.tsx
Show resolved
Hide resolved
...lic/application/main/components/no_results/no_results_suggestions/no_results_suggestions.tsx
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, congrats 🎉 ! That's a great debut in the Kibana code base. This PR fixes the issue and makes the code much clearer and better to read! Thx a lot. Works as expected in Safari, Firefox, Chrome, locally tested with a M1 Mac.
And due to the useful description you've added, I also found an issue with the existing way we handle errors. So, I deleted an index I've created for showing the new message. In this case there was an error toast displayed, that's easy to miss. I think the error should be displayed via the no_results
component. It's nothing severe, but I think we should fix it in a follow up PR. Here's an example for that, deleted the index, and the toast is easy to miss:
Kapture.2022-03-30.at.17.32.56.mp4
…lastic#128754) * [Discover] Show a fallback empty message in Discover UI when no results are found * [Discover] Update code style * [Discover] Refactor more and extract into separate components * [Discover] Revert test id * [Discover] Update code style Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Closes #126594
Summary
Next to "No results match your search criteria" title in Discover UI, we show a helpful suggestion on what can be adjusted in the search criteria (time range, search query or filters) to still find some results. This PR adds a fallback message which otherwise suggests to make sure that selected data view points to available indices with documents.
During testing, please check these cases:
Checklist