[ML] Edit job selection on data frame analytics results and map pages #130419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
force-pushed
the
ml-dfa-edit-job-selection
branch
from
243a760
to
70e42e7
Compare
alvarezmelissa87
added
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
force-pushed
the
ml-dfa-edit-job-selection
branch
from
70e42e7
to
0333293
Compare
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/page.tsx
Outdated
Show resolved
Hide resolved
| <EuiButtonEmpty | ||
| size="xs" | ||
| iconType="pencil" | ||
| onClick={() => setIsIdSelectorFlyoutVisible(true)} |
There was a problem hiding this comment.
nit, could be
onClick={setIsIdSelectorFlyoutVisible.bind(null, true)}There was a problem hiding this comment.
updated in 9b80e44
peteharverson
added
release_note:enhancement
and removed
release_note:skip
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Apr 20, 2022
dmlemeshko
pushed a commit
to dmlemeshko/kibana
that referenced
this pull request
May 5, 2022
…map pages (elastic#130419) * add selection flyout control * always allow selection flyout to be opened * show flyout when no job is selected * lint fix * show badge when id selected
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…map pages (elastic#130419) * add selection flyout control * always allow selection flyout to be opened * show flyout when no job is selected * lint fix * show badge when id selected
lcawl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129284
Checklist
Delete any items that are not applicable to this PR.