Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev Tools] Fix cat APIs returning as escaped string #130638

Merged
merged 2 commits into from Apr 21, 2022
Merged

[Dev Tools] Fix cat APIs returning as escaped string #130638

merged 2 commits into from Apr 21, 2022

Conversation

mibragimov
Copy link
Contributor

@mibragimov mibragimov commented Apr 20, 2022 •
edited

Closes #130635
Closes #130518

Summary

Fixes escaped strings for text/plain in editor output

Testing

GET _cat/templates

Output

Capture

@mibragimov mibragimov added Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0 labels Apr 20, 2022
@mibragimov mibragimov requested a review from a team as a code owner April 20, 2022 08:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
console 399.5KB 399.5KB +20.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sabarasaba
sabarasaba approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes lgtm, thanks for patching this up @mibragimov !

@mibragimov mibragimov merged commit 6e8d198 into elastic:main Apr 21, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 21, 2022
@mibragimov mibragimov deleted the console/escaped-strings branch April 21, 2022 09:25
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@mibragimov @dmlemeshko
[Dev Tools] Fix cat APIs returning as escaped string (elastic#130638)
a341086 
* Fix escaped strings

* Add tests

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@mibragimov @kertal
[Dev Tools] Fix cat APIs returning as escaped string (elastic#130638)
a02109d 
* Fix escaped strings

* Add tests

Co-authored-by: Muhammad Ibragimov <muhammad.ibragimov@elastic.co>
@mibragimov mibragimov mentioned this pull request May 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

@alexwizp alexwizp Awaiting requested review from alexwizp

@hro-maker hro-maker Awaiting requested review from hro-maker

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Console Dev Tools Console Feature Feature:Dev Tools release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dev Tools] cat APIs returning as escaped string _cat/indices API output looks odd, like a quoted string
5 participants
@mibragimov @elasticmachine @kibana-ci @sabarasaba @kibanamachine