-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unified search] Allows the negative character on the number type fields #130653
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @stratoula , did not test locally, but the code LGTM. Left a couple of nits to your discretion.
src/plugins/unified_search/public/filter_bar/filter_editor/value_input_type.tsx
Outdated
Show resolved
Hide resolved
src/plugins/unified_search/public/filter_bar/filter_editor/value_input_type.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…lds (elastic#130653) * [Unified search] Allows the negative character on the number type fields * Address PR commnets Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…lds (elastic#130653) * [Unified search] Allows the negative character on the number type fields * Address PR commnets Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Summary
Closes #115271
When a user wants to create a filter based on a number field, a number input is rendered. There is a flakiness on adding a negative value. You have to first add the positive number and then backspace and add the negative char. This PR is fixing it.
Before
![uni1](https://user-images.githubusercontent.com/17003240/164206134-4f122ff3-c59f-4d77-b521-d67ab5778e07.gif)
Now
![uni2](https://user-images.githubusercontent.com/17003240/164206143-5da59a7f-3af4-44d1-a354-8af0e170a701.gif)