[Fleet] Move the agents list bulk actions from the table to a new button #131133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
added
the
release_note:skip
criamico
changed the title
30 tasks
|
@elasticmachine merge upstream |
|
the code looks good, some unit test coverage would be nice |
|
I found it a bit confusing that the Actions button is only visible if there is an agent selected. I think it would be better to make it always visible, maybe just disable the options. Apart from this, the functionality works fine on UI. |
juliaElastic
approved these changes
Apr 29, 2022
|
Thanks @juliaElastic I'll ask if this button could be always visible instead. |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @criamico |
dmlemeshko
pushed a commit
to dmlemeshko/kibana
that referenced
this pull request
May 5, 2022
…ton (elastic#131133) * [Fleet] Move the agents list bulk actions from the table to a new button * Clean up types and add divider * Split up agent list page component * Add test for bulk actions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
…ton (elastic#131133) * [Fleet] Move the agents list bulk actions from the table to a new button * Clean up types and add divider * Split up agent list page component * Add test for bulk actions Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #130259
In the agent list table, move the bulk actions to a new
Actionsbutton nearadd agentand show it when agents are selectedclear selectionaction is now beside the selectionNote: I didn't touch any additional functionality in the table, like the bulk selection or the number of agents displayed on top. I noticed that some of that logic doesn't work as one could expect, so it will need to be discussed with product first.
I extracted a couple of small components to make the table component more readable, since is currently very long.
Screenshots
Checklist
Delete any items that are not applicable to this PR.
For maintainers