New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infrastructure UI][Rules] Add recovery context to the Metric Threshold rule #131264
Merged
simianhacker
merged 6 commits into
elastic:main
from
simianhacker:issue-127078-add-recovery-context-to-metric-threshold-rule
May 25, 2022
Merged
[Infrastructure UI][Rules] Add recovery context to the Metric Threshold rule #131264
simianhacker
merged 6 commits into
elastic:main
from
simianhacker:issue-127078-add-recovery-context-to-metric-threshold-rule
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simianhacker
added
release_note:enhancement
Feature:Metrics UI
Metrics UI feature
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.3.0
labels
Apr 29, 2022
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…d-recovery-context-to-metric-threshold-rule
mgiota
reviewed
May 20, 2022
x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts
Show resolved
Hide resolved
mgiota
reviewed
May 20, 2022
x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts
Show resolved
Hide resolved
…d-recovery-context-to-metric-threshold-rule
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
mgiota
approved these changes
May 24, 2022
Kerry350
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙌
simianhacker
deleted the
issue-127078-add-recovery-context-to-metric-threshold-rule
branch
April 17, 2024 15:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:Metrics UI
Metrics UI feature
release_note:enhancement
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
Team:Infra Monitoring UI - DEPRECATED
DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
v8.3.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #127078 by adding the available context to the Metric Threshold rule.
Sample Context for Recovery Alerts