Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure UI][Rules] Add recovery context to the Metric Threshold rule #131264

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Apr 29, 2022

Summary

This PR fixes #127078 by adding the available context to the Metric Threshold rule.

Sample Context for Recovery Alerts

{
    "group": "host-4",
    "metric": {
        "condition0": "system.cpu.user.pct"
    },
    "threshold": {
        "condition0": [
            1
        ]
    },
    "timestamp": "2022-04-29T18:25:12.590Z",
    "viewInAppUrl": "/app/metrics/explorer"
}

@simianhacker simianhacker added release_note:enhancement Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.3.0 labels Apr 29, 2022
@simianhacker simianhacker requested a review from a team as a code owner April 29, 2022 18:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@simianhacker simianhacker requested a review from mgiota May 23, 2022 16:21
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #35 / endpoint Endpoint permissions: "after all" hook in "Endpoint permissions:"
  • [job] [logs] FTR Configs #35 / endpoint Endpoint permissions: "before all" hook in "Endpoint permissions:"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Kerry350 Kerry350 self-requested a review May 24, 2022 09:45
@simianhacker simianhacker enabled auto-merge (squash) May 24, 2022 16:58
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@simianhacker simianhacker merged commit a9b5881 into elastic:main May 25, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 25, 2022
@simianhacker simianhacker deleted the issue-127078-add-recovery-context-to-metric-threshold-rule branch April 17, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Metrics UI Metrics UI feature release_note:enhancement Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI][Rules] Specify recovery context for Metric Threshold rule type
6 participants