[Stack Monitoring] Prevent exceptions in rule when no data present #131332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miltonhultgren
added
release_note:fix
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
crespocarlos
reviewed
May 3, 2022
| if (!response.aggregations) { | ||
| return stats; | ||
| } | ||
|
|
||
| // @ts-expect-error declare aggegations type explicitly | ||
| const { buckets: remoteClusterBuckets = [] } = response.aggregations?.remote_clusters; |
There was a problem hiding this comment.
Since we have that new check above, do we still need to keep the question mark here response.aggregations??
There was a problem hiding this comment.
Nope, will change that!
|
LGTM : ! Better even would be if response could be properly typed in the future |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Bamieh
pushed a commit
to Bamieh/kibana
that referenced
this pull request
May 16, 2022
…lastic#131332) * [Stack Monitoring] Prevent exceptions in rule when no data present (elastic#120111) * Remove optional chaining Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120111
When there is no data, the aggregations property of the ES response is omitted. When we then try to destructure that to get the buckets we run into a null pointer exception.
This PR simply adds a check to each affected rule to see if there are aggregations on the response object, if not we return early.
As a follow up we need decide how to inform the user that these rules are doing nothing (just eating CPU) until some data is present or they are disabled.