Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet APM Integration] static Java agent version list becomes stale quickly #131759

Merged
merged 6 commits into from
May 11, 2022
Merged

[Fleet APM Integration] static Java agent version list becomes stale quickly #131759

merged 6 commits into from
May 11, 2022

Conversation

cauemarcondes
Copy link
Contributor

closes #129866

java.version.mov

Screen Shot 2022-05-06 at 1 28 13 PM

@cauemarcondes cauemarcondes requested a review from a team as a code owner May 6, 2022 17:29
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes cauemarcondes mentioned this pull request May 6, 2022
Closed
@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

@cauemarcondes
Copy link
Contributor Author

@elasticmachine merge upstream

gbamparop
gbamparop approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've added some comments on the PR

...apm/public/components/fleet_integration/apm_agents/runtime_attachment/runtime_attachment.tsx Outdated Show resolved Hide resolved
x-pack/plugins/apm/public/components/fleet_integration/apm_agents/runtime_attachment/index.tsx Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.8MB 2.8MB +68.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
apm 92 93 +1

Total ESLint disabled count

id before after diff
apm 107 108 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit 15ca113 into elastic:main May 11, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 11, 2022
@cauemarcondes cauemarcondes deleted the apm-java-attachment branch May 11, 2022 19:52
academo pushed a commit to academo/kibana that referenced this pull request May 12, 2022
@cauemarcondes @kibanamachine
[Fleet APM Integration] static Java agent version list becomes stale …
0dd0010 
…quickly (elastic#131759)

* changing version field to text input

* disable save button

* fixing storybook

* adding doc links

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@gbamparop gbamparop mentioned this pull request May 31, 2022
Closed
@dannycroft dannycroft mentioned this pull request Jun 2, 2022
Closed
@ogupte ogupte mentioned this pull request Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet APM Integration] static Java agent version list becomes stale quickly
5 participants
@cauemarcondes @elasticmachine @kibana-ci @gbamparop @kibanamachine