Fix link to open new window #131930
Merged
Fix link to open new window #131930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
jughosta
reviewed
May 11, 2022
| @@ -409,7 +409,7 @@ export function DiscoverFieldSearch({ onChange, value, types, presentFieldTypes | |||
| defaultMessage: 'Learn more about', | |||
| })} | |||
| | |||
| <EuiLink href={docLinks.links.discover.fieldTypeHelp}> | |||
| <EuiLink href={docLinks.links.discover.fieldTypeHelp} target="_blank" external> | |||
There was a problem hiding this comment.
It would great to move the dot out of the link and the localized FormattedMessage to prevent this view:
<FormattedMessage
id="discover.fieldTypesPopover.fieldTypesDocLinkLabel"
defaultMessage="field types"
/>
jughosta
added
Feature:Discover
|
buildkite test this |
💛 Build succeeded, but was flakyFailed CI StepsTest Failures
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
academo
pushed a commit
to academo/kibana
that referenced
this pull request
May 12, 2022
* Fix link to open new window * Fix review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a correction to the front-end link.
Added
externalto props to open new window.fix #131872