-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Changes to bulk upgrade api for allowing rolling upgrades #131947
[Fleet] Changes to bulk upgrade api for allowing rolling upgrades #131947
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Pinging @elastic/fleet (Team:Fleet) |
|
||
// Check the installed fleet server versions | ||
// Allow upgrading if the agents to upgrade include fleet server agents | ||
const checkFleetServerVersion = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering if we should move this check inside the upgrade service in the isUpgradable
function
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @criamico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Summary
Part of #130259
Change restrictions in the bulk upgrade API:
I'm having some trouble with the integration tests, however I put the PR up for review since the code is completed.
Testing
Test 1
The endpoint should return 200.
Test 2
8.1.0
)The endpoint should return 400
Test 3
8.1.0
)The endpoint should return 200