Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix time shift bug #132000

Merged
merged 3 commits into from May 12, 2022
Merged

[Lens] Fix time shift bug #132000

merged 3 commits into from May 12, 2022

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented May 11, 2022

Fixes #131889

The newly introduced extendToTimeRange setting does not work together with time shifts (because there is just a single date_histogram agg for all shifted time ranges - the extended bounds will work for the original non shifted time range and have a strange effect on all shifted time ranges:

  • Bounds are not actually extended to the shifted bounds
  • Empty buckets appear for the regular time range which causes the linked bug

As there is no way to make extended bounds work with time shifts in the current setup, this PR is disabling extended bounds as soon as time shifts are present.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:AppServicesSv Feature:Lens auto-backport Deprecated: Automatically backport this PR after it's merged v8.3.0 v8.2.1 labels May 11, 2022
@flash1293
Copy link
Contributor Author

@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review May 11, 2022 10:03
@flash1293 flash1293 requested a review from a team as a code owner May 11, 2022 10:03
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 414.2KB 414.2KB +31.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@flash1293 flash1293 merged commit d6805f9 into elastic:main May 12, 2022
kibanamachine pushed a commit that referenced this pull request May 12, 2022
(cherry picked from commit d6805f9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 12, 2022
(cherry picked from commit d6805f9)

Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated: Automatically backport this PR after it's merged Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.1 v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] XY chart time range off when time shift is used
4 participants