Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Allow to cancel agent actions #132168

Merged
merged 3 commits into from
May 16, 2022
Merged

[Fleet] Allow to cancel agent actions #132168

merged 3 commits into from
May 16, 2022

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented May 12, 2022 •
edited
Loading

Summary

Related to #130259

Introduce a new API that allow to cancel an agent action

POST /api/fleet/agents/actions/{actionId}/cancel

This will create a new CANCEL action with the original id inside data.target_id for the agents targeted by the original agent.

Depends on agent change here elastic/elastic-agent#419

@nchaulet nchaulet added Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 labels May 12, 2022
@nchaulet nchaulet requested a review from a team as a code owner May 12, 2022 18:38
@nchaulet nchaulet self-assigned this May 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet nchaulet added the release_note:skip Skip the PR/issue when compiling release notes label May 12, 2022
@nchaulet nchaulet mentioned this pull request May 12, 2022
Closed
30 tasks
criamico
criamico approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 1269 1271 +2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 90.9KB 91.1KB +119.0B
Unknown metric groups

API count

id before after diff
fleet 1391 1393 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @nchaulet

@nchaulet nchaulet merged commit 8f4f4cd into elastic:main May 16, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2022
@nchaulet nchaulet deleted the feature-fleet-cancel-agent-actions branch May 16, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@nchaulet nchaulet

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nchaulet @elasticmachine @kibana-ci @criamico @kibanamachine