Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Add session ID to highlighted fields #132219

Merged
merged 5 commits into from
May 24, 2022
Merged

[SecuritySolution] Add session ID to highlighted fields #132219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
86c0390
feat: add session id to highlighted fields
janmonschke May 16, 2022
5fe6b0a
Merge branch 'main' into security/session-indo-in-highlighted-fields
kibanamachine May 16, 2022
195743a
Merge branch 'main' into security/session-indo-in-highlighted-fields
kibanamachine May 18, 2022
ca59780
Merge branch 'main' into security/session-indo-in-highlighted-fields
kibanamachine May 23, 2022
59a03d0
Merge branch 'main' into security/session-indo-in-highlighted-fields
kibanamachine May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions x-pack/plugins/security_solution/public/common/components/event_details/__mocks__/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@ export const mockAlertDetailsData = [
{ category: 'process', field: 'process.name', values: ['-'], originalValue: '-' },
{ category: 'process', field: 'process.pid', values: [0], originalValue: 0 },
{ category: 'process', field: 'process.executable', values: ['-'], originalValue: '-' },
{
category: 'process',
field: 'process.entry_leader.entity_id',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just confirm with the AWP team that this value is the best one for us to use. I think so, but want to make sure nothing has changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with them offline 👍

values: ['2938b3f873b4f3n84f938'],
originalValue: '2938b3f873b4f3n84f938',
},
{
category: 'agent',
field: 'agent.hostname',
Expand Down
10 changes: 9 additions & 1 deletion ...gins/security_solution/public/common/components/event_details/alert_summary_view.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import { useRuleWithFallback } from '../../../detections/containers/detection_en
import { TestProviders, TestProvidersComponent } from '../../mock';
import { TimelineId } from '../../../../common/types';
import { mockBrowserFields } from '../../containers/source/mock';
import * as i18n from './translations';

jest.mock('../../lib/kibana');

Expand Down Expand Up @@ -68,7 +69,14 @@ describe('AlertSummaryView', () => {
</TestProviders>
);

['host.name', 'user.name', 'Rule type', 'query', 'Source event id'].forEach((fieldId) => {
[
'host.name',
'user.name',
i18n.RULE_TYPE,
'query',
i18n.SOURCE_EVENT_ID,
i18n.SESSION_ID,
].forEach((fieldId) => {
expect(getByText(fieldId));
});
});
Expand Down
1 change: 1 addition & 0 deletions ...ugins/security_solution/public/common/components/event_details/get_alert_summary_rows.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const alwaysDisplayedFields: EventSummaryField[] = [
{ id: 'user.name' },
{ id: ALERT_RULE_TYPE, label: i18n.RULE_TYPE },
{ id: 'kibana.alert.original_event.id', label: i18n.SOURCE_EVENT_ID },
{ id: 'process.entry_leader.entity_id', label: i18n.SESSION_ID },
];

/**
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugins/security_solution/public/common/components/event_details/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,7 @@ export const VIEW_RULE_DETAIL_PAGE = i18n.translate(
export const VIEW_ALL_FIELDS = i18n.translate('xpack.securitySolution.eventDetails.viewAllFields', {
defaultMessage: 'View all fields in table',
});

export const SESSION_ID = i18n.translate('xpack.securitySolution.eventDetails.sessionId', {
defaultMessage: 'Session ID',
});