Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Session Viewer]Timestamp issue fix + updated Jest to include mock date format #132290

Merged
merged 4 commits into from
May 17, 2022
Merged

[Session Viewer]Timestamp issue fix + updated Jest to include mock date format #132290

merged 4 commits into from
May 17, 2022

Conversation

animehart
Copy link
Contributor

Summary

Fix for Timestamp issue on Session View Terminal and Alerts
#130611

@animehart animehart requested review from mitodrummer, zizhouW, opauloh and a team May 16, 2022 22:30
@animehart animehart linked an issue May 16, 2022 that may be closed by this pull request
[Session View] Date format should use Kibana settings #130611
Closed
zizhouW
zizhouW approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@zizhouW zizhouW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor things, and be sure to add the labels

x-pack/plugins/session_view/public/components/process_tree_node/index.tsx Show resolved Hide resolved
x-pack/plugins/session_view/public/components/detail_panel_alert_list_item/index.tsx Outdated Show resolved Hide resolved
@animehart animehart added Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.3.0 release_note:feature Makes this part of the condensed release notes labels May 17, 2022
opauloh
opauloh approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a small comment

@opauloh
Copy link
Contributor

opauloh commented May 17, 2022

Also, I suggest changing the label to release_note: fix, and including the [Session Viewer] prefix on the title, so people know where this fix applies to.

@animehart animehart changed the title Timestamp issue fix + updated Jest to include mock date format [Session Viewer]Timestamp issue fix + updated Jest to include mock date format May 17, 2022
@animehart animehart added release_note:fix and removed release_note:feature Makes this part of the condensed release notes labels May 17, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
sessionView 112 113 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sessionView 73.7KB 73.7KB +76.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@animehart animehart merged commit 89a90fc into elastic:main May 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zizhouW zizhouW zizhouW approved these changes

@opauloh opauloh opauloh approved these changes

@mitodrummer mitodrummer Awaiting requested review from mitodrummer

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:fix Team: AWP: Visualization AWP team that does most fullstack work in kibana v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Session View] Date format should use Kibana settings
5 participants
@animehart @opauloh @kibana-ci @zizhouW @kibanamachine