[ML] Support version fields in anomaly detection wizards #132606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
darnautov
approved these changes
May 20, 2022
.../plugins/ml/public/application/services/new_job_capabilities/new_job_capabilities_service.ts
Show resolved
Hide resolved
jgowdyelastic
commented
May 20, 2022
| @@ -205,6 +205,7 @@ export const getDataGridSchemaFromESFieldType = ( | |||
| break; | |||
| // keep schema undefined for text based columns | |||
| case ES_FIELD_TYPES.KEYWORD: | |||
| case ES_FIELD_TYPES.VERSION: | |||
There was a problem hiding this comment.
This change should have no effect, as this last collection of cases essentially behave like a default
But adding version here for completeness.
droberts195
reviewed
May 20, 2022
| if (categorizationFieldType === ES_FIELD_TYPES.KEYWORD) { | ||
| if ( | ||
| categorizationFieldType === ES_FIELD_TYPES.KEYWORD || | ||
| categorizationFieldType === ES_FIELD_TYPES.VERSION |
There was a problem hiding this comment.
Categorization is one place where we shouldn't let people choose a version field. Trying to categorize 7.17.3 and 8.2.1 will not work well. All the values will end up with zero tokens going through to the inner categorizer as we ignore numbers.
There was a problem hiding this comment.
Removed in 63c9e1c
peteharverson
approved these changes
May 23, 2022
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version field types should be supported by the wizards and should be seen as categorical fields to be used to split the data.
Fixes #132594