Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Updates Timeline tooltips to use action words / fewer words #132756

Merged

Commits on May 24, 2022

  1. ## [Security Solution] Updates Timeline tooltips to use action words …

    …/ fewer words
    
    - This PR updates the row-level action button tooltips in Timeline, per issue <elastic#126973>, to use action words / fewer words. This brings the tooltips up to date with the latest [EUI Guidelines](https://elastic.github.io/eui/#/navigation/button/guidelines).
    - The tooltips now differentiate between events and alerts. (The original tooltips were written before the Security Solution shipped with a detection engine, so there was no prior distinction.)
    
    ### Alert tooltips
    
    This section contains before / after screenshots for alerts.
    
    #### Before: Unpinned alert
    
    ![01-BEFORE-unpinned-alert](https://user-images.githubusercontent.com/4459398/169910015-ec5789c2-a691-4e48-b375-c95d15db8378.png)
    
    #### After: Unpinned alert
    
    ![01-AFTER-unpinned-alert](https://user-images.githubusercontent.com/4459398/169910149-0cdd8c65-a9b0-43b6-8550-cd0d9c512b17.png)
    
    #### Before: Pinned alert
    
    ![02-BEFORE-pinned-alert](https://user-images.githubusercontent.com/4459398/169910207-27aa3307-d33d-4fb5-9ff7-042a6adf030e.png)
    
    #### After: Pinned alert
    
    ![02-AFTER-pinned-alert](https://user-images.githubusercontent.com/4459398/169910265-087a3779-2330-437d-b83f-d887eb4adaf9.png)
    
    #### Before: Add a note to an alert
    
    ![03-BEFORE-alert-add-note](https://user-images.githubusercontent.com/4459398/169910347-39ca30db-a010-4739-b67f-464851730218.png)
    
    #### After: Add a note to an alert
    
    ![03-AFTER-alert-add-note](https://user-images.githubusercontent.com/4459398/169910407-510ff4f3-e0ee-4649-8a44-5b7411a5b629.png)
    
    #### Before: A pinned alert with notes
    
    ![04-BEFORE-pinned-alert-with-notes](https://user-images.githubusercontent.com/4459398/169910491-59869c08-2b2b-4c42-a39b-4d4efc05e668.png)
    
    #### After: A pinned alert with notes
    
    ![04-AFTER-pinned-alert-with-notes](https://user-images.githubusercontent.com/4459398/169910573-7ae31f88-1199-4744-ae5e-54b40d3c34cb.png)
    
    #### Before: A timeline template with alerts
    
    ![05-BEFORE-alert-template](https://user-images.githubusercontent.com/4459398/169910699-03ead1dd-d543-4687-a6f3-14b1b95023aa.png)
    
    #### After: A timeline template with alerts
    
    ![05-AFTER-alert-template](https://user-images.githubusercontent.com/4459398/169910740-120eb087-111f-42e9-bb24-af3c344e68c7.png)
    
    ### Event tooltips
    
    This section contains before / after screenshots for events.
    
    #### Before: Unpinned event
    
    ![06-BEFORE-unpinned-event](https://user-images.githubusercontent.com/4459398/169911532-047d07e2-b4b2-4719-a1a9-fe67c9e04162.png)
    
    #### After: Unpinned event
    
    ![06-AFTER-unpinned-event](https://user-images.githubusercontent.com/4459398/169911561-3c452e5b-23de-4144-b0c9-3e805fbd4021.png)
    
    #### Before: Pinned event
    
    ![07-BEFORE-pinned-event](https://user-images.githubusercontent.com/4459398/169911699-ffde9799-6120-49e0-8012-37dd687bba31.png)
    
    #### After: Pinned event
    
    ![07-AFTER-pinned-event](https://user-images.githubusercontent.com/4459398/169911741-48eeba36-a2c3-4a53-b5f6-57c376b82aa0.png)
    
    #### Before: Add a note to event
    
    ![08-BEFORE-event-add-note](https://user-images.githubusercontent.com/4459398/169911867-4139d719-dd5d-4e1b-a415-08863cbf9897.png)
    
    #### After: Add a note to an event
    
    ![08-AFTER-event-add-note](https://user-images.githubusercontent.com/4459398/169911895-ea537e8e-9457-4f30-adcc-7ca03c35ea68.png)
    
    #### Before: A pinned event with notes
    
    ![09-BEFORE-pinned-event-with-notes](https://user-images.githubusercontent.com/4459398/169911931-9bb662b7-21ea-414b-99c2-46706763ac01.png)
    
    #### After: A pinned event with notes
    
    ![09-AFTER-pinned-event-with-notes](https://user-images.githubusercontent.com/4459398/169911975-fc7901ff-61d2-4b6d-b47f-62bf38d4ca16.png)
    
    #### Before: A timeline template with events
    
    ![10-BEFORE-event-template](https://user-images.githubusercontent.com/4459398/169911994-4df648ad-bfc7-44ec-bcd5-602a6edb6ca1.png)
    
    #### After: A timeline template with events
    
    ![10-AFTER-event-template](https://user-images.githubusercontent.com/4459398/169912017-ac54d03d-11ab-4116-ab33-6d20d5cbba37.png)
    andrew-goldstein committed May 24, 2022
    Configuration menu
    Copy the full SHA
    ee5e524 View commit details
    Browse the repository at this point in the history
  2. - pr feedback

    andrew-goldstein committed May 24, 2022
    Configuration menu
    Copy the full SHA
    ce0c17d View commit details
    Browse the repository at this point in the history