Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove mentions of apm_user #132790

Merged
merged 3 commits into from May 25, 2022
Merged

[APM] Remove mentions of apm_user #132790

merged 3 commits into from May 25, 2022

Conversation

sorenlouv
Copy link
Member

Closes #116760

@sorenlouv sorenlouv marked this pull request as ready for review May 24, 2022 13:51
@sorenlouv sorenlouv requested review from a team as code owners May 24, 2022 13:51
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #44 / context app context link in discover should navigate to the first document and then back to discover

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 15 14 -1

Total ESLint disabled count

id before after diff
apm 99 98 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 release_note:deprecation and removed release_note:skip Skip the PR/issue when compiling release notes labels May 24, 2022
Copy link
Contributor

@gbamparop gbamparop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for doing this! APM changes LGTM!

@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label May 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

defined in <<apm-settings-kb,`xpack.observability.annotations.index`>> has been customized.
NOTE: By default, the `viewer` and `editor` built-in roles provide read access to Observability annotations.
You only need to create an annotation user to write to the annotations index
(<<apm-settings-kb,`xpack.observability.annotations.index`>>).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmorelli25 fyi: We are removing all references to apm_user role since it is deprecated and we want users to use editor and viewer roles.

@sorenlouv sorenlouv merged commit c1b77b9 into main May 25, 2022
@sorenlouv sorenlouv deleted the remove-apm_user branch May 25, 2022 10:07
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 25, 2022
pugnascotia pushed a commit to elastic/elasticsearch that referenced this pull request Jul 5, 2023
Meta issue: elastic/kibana#116760

The `apm_user` role was marked as deprecated in 7.13 and was supposed to be removed in 8.0 but it
didn't happen. Now we are aiming to remove the role in 9.0 and are updating the deprecation message.

All mentions of `apm_user` role have been removed from docs and in-product mentions
in elastic/kibana#132790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:deprecation Team:APM All issues that need APM UI Team support v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Replace apm_user with stack-wide roles (editor / viewer)
6 participants