-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Optimize resize behaviour for the Anomaly Explorer page #132820
[ML] Optimize resize behaviour for the Anomaly Explorer page #132820
Conversation
Pinging @elastic/ml-ui (:ml) |
return this._swimLaneBucketInterval$.pipe(skipWhile((v) => !v)); | ||
public getSwimLaneBucketInterval$(): Observable<TimeBucketsInterval> { | ||
return this._swimLaneBucketInterval$.pipe( | ||
// @ts-ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, can you please add a reason for the ignore, should it be an expect error instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM
💚 Build SucceededMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @darnautov |
Summary
Part of #124696
Refetches swim lanes data only on the actual bucket interval change instead of every (insignificant) window resize.
Checklist