Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Optimize resize behaviour for the Anomaly Explorer page #132820

Merged
merged 1 commit into from
May 24, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 24, 2022

Summary

Part of #124696

Refetches swim lanes data only on the actual bucket interval change instead of every (insignificant) window resize.

Checklist

@darnautov darnautov added release_note:enhancement :ml Feature:Anomaly Detection ML anomaly detection Team:ML Team label for ML (also use :ml) v8.3.0 labels May 24, 2022
@darnautov darnautov requested a review from a team as a code owner May 24, 2022 15:20
@darnautov darnautov self-assigned this May 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

return this._swimLaneBucketInterval$.pipe(skipWhile((v) => !v));
public getSwimLaneBucketInterval$(): Observable<TimeBucketsInterval> {
return this._swimLaneBucketInterval$.pipe(
// @ts-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, can you please add a reason for the ignore, should it be an expect error instead?

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.3MB 3.3MB -8.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

@darnautov darnautov merged commit b758969 into elastic:main May 24, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 24, 2022
@darnautov darnautov deleted the ml-124696-optimize-charts-resize branch May 24, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants